Skip to content

feat(rollup-plugin-html): add CSS bundling and minification#3027

Merged
bashmish merged 1 commit intomasterfrom
feat/css-bundling-and-minification
Feb 3, 2026
Merged

feat(rollup-plugin-html): add CSS bundling and minification#3027
bashmish merged 1 commit intomasterfrom
feat/css-bundling-and-minification

Conversation

@bashmish
Copy link
Member

@bashmish bashmish commented Feb 3, 2026

What I did

  1. implement bundling and minification via Lightning CSS
  2. enable CSS bundling by default since otherwise @import won't be properly working in the output, so I consider this a feature/bugfix
  3. do not enable CSS minification by default, in accordance with existing HTML minification rule
  4. due to how things are implemented, the output CSS will always be processed by Lightning CSS, resulting in normalization of some CSS properties, therefore tests needed to be updated and this will impact end users too, but that gives consistency in the output, which is a good thing, so I consider this a bugfix
  5. added some docs and fixed some old ones

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2026

🦋 Changeset detected

Latest commit: 3a9c97b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/rollup-plugin-html Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thepassle
Copy link
Member

thepassle commented Feb 3, 2026

The tests failing is still the same issue we had as before? Maybe we should make a story to fix them as well

Otherwise LGTM

@bashmish bashmish merged commit 6a51951 into master Feb 3, 2026
6 of 9 checks passed
@bashmish bashmish deleted the feat/css-bundling-and-minification branch February 3, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants