Open
Conversation
Signed-off-by: Jerozgen <jerozgen@gmail.com>
IMB11
approved these changes
Mar 21, 2026
IMB11
requested changes
Mar 21, 2026
| } | ||
|
|
||
| function formatCompactNumberPlural(value: number | bigint): string { | ||
| function formatCompactNumberPlural(value: number | bigint): number | bigint { |
Member
There was a problem hiding this comment.
This return type is wrong, it needs to be string.
Contributor
Author
There was a problem hiding this comment.
The formatCompactNumber function returns a compact number as a string
The formatCompactNumberPlural function is used in ICU plural messages ({(here!), plural, ...}). This plural variable is internally converted to a number for category matching (one, few, other, etc.), so it doesn't matter whether this function returns a string or a number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made ICU to use the
onebranch for compact numbers (10K, 1.23M) in Filipino