Skip to content

Revert NettyByteBuf.asReadOnly change #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rozza wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Revert NettyByteBuf.asReadOnly change #1871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31bb738
Revert NettyByteBuf.asReadOnly change
rozza Jan 28, 2026
68b288f
Remove out of date comment
rozza Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion driver-core/src/main/com/mongodb/internal/connection/netty/NettyByteBuf.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ public ByteBuf limit(final int newLimit) {

@Override
public ByteBuf asReadOnly() {
return new NettyByteBuf(proxied.asReadOnly().retain(), false);
return this;
}

@Override
Expand Down
3 changes: 3 additions & 0 deletions ...ore/src/test/functional/com/mongodb/internal/connection/CommandHelperSpecification.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import com.mongodb.connection.SocketSettings
import com.mongodb.internal.connection.netty.NettyStreamFactory
import org.bson.BsonDocument
import org.bson.BsonInt32
import spock.lang.Ignore
import spock.lang.Specification

import java.util.concurrent.CountDownLatch
Expand Down Expand Up @@ -52,9 +53,11 @@ class CommandHelperSpecification extends Specification {
}

def cleanup() {
InternalStreamConnection.setRecordEverything(false)
connection?.close()
}

@Ignore("JAVA-5982")
def 'should execute command asynchronously'() {
when:
BsonDocument receivedDocument = null
Expand Down