PYTHON-5772 Increase _gcp_helpers.py coverage#2749
Merged
aclark4life merged 1 commit intomongodb:masterfrom Apr 14, 2026
Merged
PYTHON-5772 Increase _gcp_helpers.py coverage#2749aclark4life merged 1 commit intomongodb:masterfrom
aclark4life merged 1 commit intomongodb:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a focused unit test module to improve coverage of pymongo/_gcp_helpers.py, specifically around _get_gcp_response behavior and error handling.
Changes:
- Introduces
test/test_gcp_helpers.pywith unit tests covering success, non-200 responses, exceptions, request construction, and timeout forwarding.
NoahStapp
requested changes
Apr 9, 2026
| _get_gcp_response("https://example.com") | ||
| self.assertIn("Failed to acquire IMDS access token", str(ctx.exception)) | ||
|
|
||
| def test_urlopen_exception_raises_value_error(self): |
Contributor
There was a problem hiding this comment.
Is this test adding anything that the previous one doesn't? The previous test already contains self.assertRaises(ValueError).
Contributor
Author
There was a problem hiding this comment.
Yes, HTTP status errors != connection refused.
aclark4life
force-pushed
the
PYTHON-5772
branch
from
216af76 to
ac0f958
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
aclark4life
force-pushed
the
PYTHON-5772
branch
from
ac0f958 to
dad7f22
Compare
NoahStapp
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5772
Changes in this PR
Test Plan
Checklist
Checklist for Author
Checklist for Reviewer