Add FXIOS-15014 [RS] Expose reset _storage method to consumers#7253
Add FXIOS-15014 [RS] Expose reset _storage method to consumers#7253bendk merged 3 commits intomozilla:mainfrom
reset _storage method to consumers#7253Conversation
issammani
force-pushed
the
feat/expose-rs-reset-storage
branch
from
9dd4a68 to
8e439d3
Compare
bendk
left a comment
bendk
left a comment
There was a problem hiding this comment.
Looks good to me, I just found some minor issues. Feel free to deal with them however you want, I don't need to re-review.
| } | ||
| } | ||
|
|
||
| #[cfg(not(feature = "signatures"))] |
There was a problem hiding this comment.
Is this needed? I'd expect the test to work regardless of that feature.
There was a problem hiding this comment.
I had the test initially in lib.rs and it was failing because I was mocking the response with the signature. I don't think it's necessary now though. Thanks !
|
|
||
| rs_client.reset_storage().expect("Failed to reset storage"); | ||
|
|
||
| // After reset, both records and attachments should be gone |
There was a problem hiding this comment.
This could also test that records/attachments with packaged data are reverted to the packaged versions. I don't think that's totally necessary though, the addition of this test is already great. If you don't want test the packaged data, how about writing a comment mentioning that there could be a test.
mergify
bot
dismissed
bendk’s stale review
The pull request has been modified, dismissing previous reviews.
issammani
force-pushed
the
feat/expose-rs-reset-storage
branch
from
3233a7a to
8edd66f
Compare
bendk
left a comment
bendk
left a comment
There was a problem hiding this comment.
Still looks good, let's merge this.
2 participants
📜 Tickets
Jira ticket
Github issue
This PR:
reset_storagefor remote settings clients.Pull Request checklist
[ci full]to the PR title.