QT-OpenGL example now builds with Qt6#59
Open
SiddhantRanade wants to merge 3 commits intompv-player:masterfrom
Open
QT-OpenGL example now builds with Qt6#59SiddhantRanade wants to merge 3 commits intompv-player:masterfrom
SiddhantRanade wants to merge 3 commits intompv-player:masterfrom
Conversation
cmdrkotori
suggested changes
Nov 27, 2024
| MouseArea { | ||
| anchors.fill: parent | ||
| onClicked: renderer.command(["loadfile", "test.mkv"]) | ||
| onClicked: renderer.command(["loadfile", "C:/Users/Siddhant/Downloads/orig cut.mp4"]) |
There was a problem hiding this comment.
Please leave this as a generic test.mkv instead of a file on your own computer.
| FILENAME_VARIABLE deploy_script | ||
| NO_UNSUPPORTED_PLATFORM_ERROR | ||
| ) | ||
| install(SCRIPT ${deploy_script}) |
There was a problem hiding this comment.
This entire file is unncessary. The .pro file should be updated instead.
Comment on lines
-9
to
+10
| setlocale(LC_NUMERIC, "C"); | ||
| //setlocale(LC_NUMERIC, "C"); | ||
| // Commented because it's not compiling on macOS |
There was a problem hiding this comment.
Use #ifndef Q_OS_MAC so that other platforms will work as expected. Don't comment out the correct way of running libmpv.
| void MpvWidget::paintGL() | ||
| { | ||
| mpv_opengl_fbo mpfbo{static_cast<int>(defaultFramebufferObject()), width(), height(), 0}; | ||
| mpv_opengl_fbo mpfbo{static_cast<int>(defaultFramebufferObject()), (int) (width() * devicePixelRatio()), (int) (height() * devicePixelRatio()), 0}; |
There was a problem hiding this comment.
Use qreal dpr = devicePixelRatio() once and refer to that variable instead of calling devicePixelRatio twice.
Use new-style casts such as int(width()*dpr), not C-style casts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.