Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis change extends the hash-fns utility to support an eventSubscriptions property. The function filtering logic is updated to return true if eventSubscriptions is truthy, in addition to checking existing properties like displayName, generator, routes, buildData, priority, and trafficRules. Additionally, the function configuration output is modified to include event_subscriptions in the reduced config object alongside other fields. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
📊 Benchmark resultsComparing with 0938c79
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/utils/deploy/hash-fns.ts`:
- Around line 188-191: Prettier is failing on the filter callback that builds a
Boolean from func properties (the .filter((func) => Boolean(func.displayName ||
func.generator || func.routes || func.buildData || func.priority ||
func.trafficRules || func.eventSubscriptions)) expression); run Prettier (or
your repo's formatting script) against this file and commit the reformatted file
so the spacing/line breaks around that filter callback conform to the project's
formatting rules.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b7e3522c-1562-4e4c-b090-04b31a55d478
📒 Files selected for processing (1)
src/utils/deploy/hash-fns.ts
Part of https://linear.app/netlify/issue/RUN-2652/improve-syntax-of-event-triggered-functions.