Skip to content

feat: add function event subscriptions#8042

Open
eduardoboucas wants to merge 2 commits intomainfrom
feat/event-subscriptions
Open

feat: add function event subscriptions#8042
eduardoboucas wants to merge 2 commits intomainfrom
feat/event-subscriptions

Conversation

@eduardoboucas
Copy link
Member

@eduardoboucas eduardoboucas requested a review from a team as a code owner March 16, 2026 00:02
@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e2905cd6-dd4b-47c2-b8a5-645cf50d20ef

📥 Commits

Reviewing files that changed from the base of the PR and between bf37547 and a8ecba7.

📒 Files selected for processing (1)
  • src/utils/deploy/hash-fns.ts

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Functions now include event subscriptions in their deployment configuration, allowing explicit subscription settings to be deployed.
    • Deployment and function selection now respect event subscription settings, enabling filtering and processing based on those subscriptions for finer-grained triggering and management.

Walkthrough

This change extends the hash-fns utility to support an eventSubscriptions property. The function filtering logic is updated to return true if eventSubscriptions is truthy, in addition to checking existing properties like displayName, generator, routes, buildData, priority, and trafficRules. Additionally, the function configuration output is modified to include event_subscriptions in the reduced config object alongside other fields.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: add function event subscriptions' clearly and concisely describes the main change, which is adding event subscriptions support to functions.
Description check ✅ Passed The description references a related Linear issue tracking the broader feature work, which is meaningfully related to the changeset's purpose.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/event-subscriptions
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Mar 16, 2026

📊 Benchmark results

Comparing with 0938c79

  • Dependency count: 1,122 (no change)
  • Package size: 357 MB (no change)
  • Number of ts-expect-error directives: 362 (no change)

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/utils/deploy/hash-fns.ts`:
- Around line 188-191: Prettier is failing on the filter callback that builds a
Boolean from func properties (the .filter((func) => Boolean(func.displayName ||
func.generator || func.routes || func.buildData || func.priority ||
func.trafficRules || func.eventSubscriptions)) expression); run Prettier (or
your repo's formatting script) against this file and commit the reformatted file
so the spacing/line breaks around that filter callback conform to the project's
formatting rules.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b7e3522c-1562-4e4c-b090-04b31a55d478

📥 Commits

Reviewing files that changed from the base of the PR and between 03146de and bf37547.

📒 Files selected for processing (1)
  • src/utils/deploy/hash-fns.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant