Skip to content

Conversation

@AlvaroBrey
Copy link
Member

@AlvaroBrey AlvaroBrey commented Sep 23, 2022

Inspired by #17

get_branch.sh is meant to replace getBranchName.sh and getBranchBase.sh.

This requires some stuff to be setup in the CI environment:

  • GITHUB_TOKEN: self-explanatory, we should use the default ${{ secrets.GITHUB_TOKEN }} on Github, and a PAT on Drone.
  • GITHUB_REPOSITORY: example is nextcloud/android (including org). Can be retrieved from Github's env ( ${{ github.repository}}) and also Drone's ($DRONE_REPO)

These are env variables and not shell arguments because they are intended to be used in code common to all scripts (currently only lib.sh), so we won't need to pass them around so much.

@AlvaroBrey AlvaroBrey force-pushed the share-scripts-initial branch 3 times, most recently from 68d39a9 to 8be8e19 Compare September 23, 2022 14:44
@AlvaroBrey AlvaroBrey force-pushed the share-scripts-initial branch from 8be8e19 to 0a1a9f3 Compare September 23, 2022 14:49
@AlvaroBrey AlvaroBrey self-assigned this Sep 23, 2022
@AlvaroBrey AlvaroBrey marked this pull request as ready for review September 23, 2022 14:53
tobiasKaminsky
tobiasKaminsky previously approved these changes Sep 26, 2022
timkrueger
timkrueger previously approved these changes Sep 27, 2022
Copy link

@timkrueger timkrueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is great 👍

@AlvaroBrey AlvaroBrey marked this pull request as draft September 29, 2022 16:02
@AlvaroBrey
Copy link
Member Author

Marked as draft as I have now become aware of two incompatible uses of getBranchName and getBranchBase. For PRs, the first returns the head ref, and the latter the base ref. So I must look better into how they're used before attempting to make them common like this.

@tobiasKaminsky
Copy link
Member

If you need help, just ping me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants