Skip to content

fix(file-listing): local file indicator icon#16507

Closed
alperozturk96 wants to merge 19 commits intomasterfrom
fix/file-indicator
Closed

fix(file-listing): local file indicator icon#16507
alperozturk96 wants to merge 19 commits intomasterfrom
fix/file-indicator

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Feb 13, 2026

Issue

The folder/file sync icon does not appear while a folder is being downloaded.

After the folder/file download completes, if the folder/file is deleted, the checkmark (tick) icon remains visible and does not disappear as expected

Fix

Screen.Recording.2026-02-09.at.15.21.50.mp4

@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.36

@alperozturk96 alperozturk96 force-pushed the fix/file-indicator branch 2 times, most recently from c647bcf to dc6821a Compare February 23, 2026 09:20
@alperozturk96
Copy link
Collaborator Author

@tobiasKaminsky how can we generate screenshots to compare?

@alperozturk96 alperozturk96 marked this pull request as draft February 23, 2026 16:39
@alperozturk96 alperozturk96 force-pushed the fix/file-indicator branch 2 times, most recently from 4b0e91d to 233eac5 Compare March 3, 2026 08:23
@alperozturk96 alperozturk96 marked this pull request as ready for review March 3, 2026 08:24
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
…ator

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice4242
Correctness7575
Dodgy code253253
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4343
Security1818
Total475475

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16507.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New approach, as discussed

  • fix receiver for download, sync, delete in individual PRs.
  • use media_path in filelist (room db), if needed, do not use any async call inside OCFileListDelegate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants