fix: endless burst of requests on uncached mailboxes#11632
Draft
fix: endless burst of requests on uncached mailboxes#11632
Conversation
Signed-off-by: greta <gretadoci@gmail.com>
Signed-off-by: greta <gretadoci@gmail.com>
Contributor
Author
|
please test |
Member
|
What caused the endless loop before? |
Contributor
Author
Check the |
Member
|
Seems intentional?
|
Contributor
Author
to keep trying, yes probably. To keep trying forever, i doubt its intentional. Do you think this approach is not the solution we want? |
Member
|
The idea is to wait until the initial syncing is done. This should happen eventually. |
Member
|
Do you have an alternative for retrying until it is no longer locked? Retry should definitely stop for any other error |
Signed-off-by: greta <gretadoci@gmail.com>
Signed-off-by: greta <gretadoci@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #11024
Another approach would be if we handle initialization in sync() instead. Smth like:
if (init) { await wait(5000) await this.loadEnvelopes() }