fix(app-settings): limit app to group initial state #57533
+57
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elzody
requested review from
ArtificialOwl,
icewind1991 and
salmart-dev
and removed request for
a team
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Office team
elzody
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 📝 Office team
elzody
changed the title
juliusknorr
reviewed
Jan 13, 2026
CarlSchwan
reviewed
Jan 14, 2026
elzody
force-pushed
the
fix/limit-app-to-group-initial-state
branch
2 times, most recently
from
002dc8a to
7bd91a3
Compare
elzody
requested review from
nfebe,
sorbaugh and
susnux
and removed request for
a team
elzody
force-pushed
the
fix/limit-app-to-group-initial-state
branch
from
48486dc to
daf55db
Compare
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
elzody
force-pushed
the
fix/limit-app-to-group-initial-state
branch
from
daf55db to
90deae4
Compare
Signed-off-by: Elizabeth Danzberger <[email protected]>
juliusknorr
approved these changes
Jan 28, 2026
elzody
added
3. to review
Contributor
Author
|
Should be ready for a proper review now. Added a Cypress test for coverage. |
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
Contributor
Author
No. The front end already expects the initial state to be there, so we just need to provide it in the backend. Because it wasn't before, it was defaulting to an empty dropdown and only populated it once you started searching. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When you try to limit an app by a group, the dropdown is initially not filled with any groups. They only populate once you start typing the name of a group, which triggers a network request. This pull request provides the necessary initial state to the app list so that the groups are populated by default and you can quickly select one without searching.
TODO
Checklist
3. to review, feature component)stable32)