Security: Unbounded limit parameter in user search can be abused for resource exhaustion#8476
Open
tomaioo wants to merge 1 commit intonextcloud:mainfrom
Open
Conversation
The `index(string $filter = '', int $limit = 5)` method accepts client-controlled `limit` and passes it directly to collaborator search. Without an upper bound, an attacker can request very large limits, causing expensive directory lookups and increased response size. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
tomaioo
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Unbounded
limitparameter in user search can be abused for resource exhaustionProblem
Severity:
Medium| File:lib/Controller/UserApiController.php:L39The
index(string $filter = '', int $limit = 5)method accepts client-controlledlimitand passes it directly to collaborator search. Without an upper bound, an attacker can request very large limits, causing expensive directory lookups and increased response size.Solution
Enforce a strict maximum (e.g., 10-50) for
limitbefore invoking search, and consider server-side rate limiting for this endpoint.Changes
lib/Controller/UserApiController.php(modified)