Skip to content

Update module: ctree#10335

Open
elena-buscaroli wants to merge 13 commits intonf-core:masterfrom
elena-buscaroli:ctree
Open

Update module: ctree#10335
elena-buscaroli wants to merge 13 commits intonf-core:masterfrom
elena-buscaroli:ctree

Conversation

@elena-buscaroli
Copy link
Contributor

@elena-buscaroli elena-buscaroli commented Mar 5, 2026

PR checklist

Closes #10334

Updating versions.yml output to solve issues and update to versions topic.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@elena-buscaroli
Copy link
Contributor Author

Hi @mashehu! I updated another module similarly to #10314 and #10312, so it will have the same issue with the linting process!

assertAll(
{ assert process.success },
{ assert snapshot(process.out.versions).match() }
{ assert snapshot(process.out.versions_ctree).match() }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ assert snapshot(process.out.versions_ctree).match() }
{ assert snapshot(path(process.out.versions[0]).yaml).match() }

with that you get the version actually printed, which should make it better to track for changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionallly, how come you don't check anything else from process.out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @mashehu! I updated those lines as you suggested. also, I added some tests (to test more outputs of the module) and I noticed a small bug which I fixed

Copy link
Contributor Author

@elena-buscaroli elena-buscaroli Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just realised that the linting is not working due to assert snapshot(path(process.out.versions[0]).yaml).match(). I modified what you suggested writing versions_ctree instead of versions since that's the emit name in the main.nf and the test works, but the linting fails. Do you have any suggestion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update module: ctree

2 participants