Skip to content

Add Date::New overload for a std::chrono::system_clock::time_point#1705

Merged
legendecas merged 3 commits intonodejs:mainfrom
cacharle:add-date-new-time-point
Mar 23, 2026
Merged

Add Date::New overload for a std::chrono::system_clock::time_point#1705
legendecas merged 3 commits intonodejs:mainfrom
cacharle:add-date-new-time-point

Conversation

@cacharle
Copy link
Contributor

Fixes #1704

@cacharle
Copy link
Contributor Author

Not too sure how to add a unit test for this since it seems they're being done in JS

@cacharle cacharle marked this pull request as ready for review February 1, 2026 17:11
@legendecas
Copy link
Member

@cacharle
Copy link
Contributor Author

cacharle commented Feb 3, 2026

Added some basic unit test, npm test takes too long to compile, how can I compile in parallel?

@legendecas legendecas moved this from Need Triage to In Progress in Node-API Team Project Feb 13, 2026
Copy link
Contributor

@KevinEady KevinEady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guards for c++11 can be removed.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.56%. Comparing base (86a0524) to head (6dda28f).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1705      +/-   ##
==========================================
+ Coverage   63.50%   63.56%   +0.05%     
==========================================
  Files           3        3              
  Lines        2047     2053       +6     
  Branches      728      729       +1     
==========================================
+ Hits         1300     1305       +5     
  Misses        162      162              
- Partials      585      586       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KevinEady KevinEady self-requested a review March 22, 2026 23:02
@legendecas legendecas merged commit 7fb063d into nodejs:main Mar 23, 2026
60 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Node-API Team Project Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Add Date::New for std::chrono::system_clock::time_point

4 participants