sqlite: bind ArrayBuffer

[mike-git374]

Fixes: #61396

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[Renegade334]

I feel like this is probably reasonable, given that we already allow non-Uint8Array array buffer views. There are certain API surfaces that return raw ArrayBuffers (thinking webcrypto in particular), the required change is a one-liner, and there's already asymmetry in terms of the type conversion for BLOBs.

[codecov]

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.64%. Comparing base (c9acf34) to head (1f2afe9).
⚠️ Report is 84 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	33.33%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62061      +/-   ##
==========================================
- Coverage   89.74%   89.64%   -0.11%     
==========================================
  Files         674      676       +2     
  Lines      204883   206242    +1359     
  Branches    39379    39506     +127     
==========================================
+ Hits       183882   184889    +1007     
- Misses      13279    13467     +188     
- Partials     7722     7886     +164     

Files with missing lines	Coverage Δ
src/node_sqlite.cc	80.70% <33.33%> (-0.20%)	⬇️

... and 154 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Renegade334]

The following line also needs to be updated, so that array buffers aren't treated as named parameter binding objects:

node/src/node_sqlite.cc

Line 2164 in 1f2afe9

if (args[0]->IsObject() && !args[0]->IsArrayBufferView()) {

[Renegade334]

It would be better if you tested this behaviour by adding to test/parallel/test-sqlite-typed-array-and-data-view.js instead (you can also add cases for both ArrayBuffer and SharedArrayBuffer).

This also has the benefit of passing array buffers in the first binding argument, which tests the object binding behaviour mentioned above.