doc: fix markdown for expectFailure values#62100
Merged
nodejs-github-bot merged 4 commits intonodejs:mainfrom Mar 4, 2026
Merged
doc: fix markdown for expectFailure values#62100nodejs-github-bot merged 4 commits intonodejs:mainfrom
expectFailure values#62100nodejs-github-bot merged 4 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
JakobJingleheimer
added
the
fast-track
nodejs-github-bot
added
doc
Contributor
|
Fast-track has been requested by @JakobJingleheimer. Please 👍 to approve. |
JakobJingleheimer
requested review from
Ethan-Arrowood,
avivkeller and
pmarchini
aduh95
reviewed
Mar 4, 2026
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Mar 4, 2026
Contributor
|
Can we also fix Lines 1734 to 1737 in 3540fae |
cjihrig
approved these changes
Mar 4, 2026
aduh95
approved these changes
Mar 4, 2026
aduh95
added
author ready
Ethan-Arrowood
approved these changes
Mar 4, 2026
Member
Author
|
@aduh95 thanks! I see you added the labels too (but left it author-ready). Mind if I send it to the commit queue? I think it has enough PR and fast-track approvals to go. |
Renegade334
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 23ba205 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, about half the test API doc is broken (text outside of codeblocks below here is blank).