deps: V8: override depot_tools version#62344
Open
richardlau wants to merge 1 commit intonodejs:mainfrom
Open
Conversation
For compatibility with Python >= 3.12 we need a newer version of `depot_tools` than is used for the older versions of V8.
richardlau
added
lts-watch-v20.x
This comment was marked as duplicate.
This comment was marked as duplicate.
2 tasks
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For compatibility with Python >= 3.12 we need a newer version of
depot_toolsthan is used for the older versions of V8.Refs: nodejs/build#4278
cc @nodejs/v8-update
This will need to be cherry-picked onto all release lines that we want to run the V8 CI on as it is necessary to run on Ubuntu 24.04 where the default Python 3 is 3.12.
We should also undo it with/after #61898 (or newer V8) as that will set a new enough version of
depot_toolsto be Python 3.12 compatible.