test: normalize known inspector crash as completion#62851
Open
joyeecheung wants to merge 4 commits intonodejs:mainfrom
Open
test: normalize known inspector crash as completion#62851joyeecheung wants to merge 4 commits intonodejs:mainfrom
joyeecheung wants to merge 4 commits intonodejs:mainfrom
Conversation
This works around a pre-existing inspector issue: if the debuggee exits too quickly the inspector can segfault while tearing down. For now normalize the trailing segfault as completion to keep the CI green until the upstream bug is fixed, since it only reproduces on some slow CI machines and is not what the probe tests care about.
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62851 +/- ##
=======================================
Coverage 89.62% 89.63%
=======================================
Files 706 706
Lines 219136 219185 +49
Branches 41987 41991 +4
=======================================
+ Hits 196404 196456 +52
- Misses 14611 14621 +10
+ Partials 8121 8108 -13 🚀 New features to boost your workflow:
|
Member
Author
hybrist
approved these changes
Apr 20, 2026
Contributor
|
I was about to suggest something about |
github-actions
Bot
removed
the
request-ci
Collaborator
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
legendecas
approved these changes
Apr 22, 2026
JakobJingleheimer
approved these changes
Apr 22, 2026
Member
Author
|
Looks like there's a test where it should be normalized to "missed". Updated the logic a bit to accommodate it. |
Collaborator
JakobJingleheimer
approved these changes
Apr 22, 2026
Comment on lines
+28
to
+29
| normalized.results[normalized.results.length - 1] = | ||
| expected.results[expected.results.length - 1]; |
Member
There was a problem hiding this comment.
nit: this is far easier to grok (almost said last time, but seeing it again, it really is)
Suggested change
| normalized.results[normalized.results.length - 1] = | |
| expected.results[expected.results.length - 1]; | |
| normalized.results.at(-1) = expected.results.at(-1); |
Member
Author
There was a problem hiding this comment.
hmm, wait I don't think the LHS can use it
Member
Author
There was a problem hiding this comment.
Left hand side.
> [0,1].at(-1) = 1
Uncaught ReferenceError: Invalid left-hand side in assignment
at <anonymous>:1:7
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
joyeecheung
commented
Apr 23, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works around a pre-existing inspector issue: if the debuggee exits too quickly the inspector can segfault while tearing down. For now normalize the trailing segfault as completion to keep the CI green until the upstream bug is fixed, since it only reproduces on some slow CI machines and is not what the probe tests care about.
Refs: #62765
Refs: #58245