Skip to content

fix(ui): Sidebar scroll not showing last element #8563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
malav2110 wants to merge 6 commits into
base: main
Choose a base branch
from
+4 −2
Open

fix(ui): Sidebar scroll not showing last element #8563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6289850
fix(ui): Sidebar scroll not showing last element
malav2110 Jan 26, 2026
e7054d2
fix(ui): correct sidebar sticky positioning for better visibility
malav2110 Jan 27, 2026
8bb2784
Merge branch 'nodejs:main' into fix-sidebar-scroll-last-item
malav2110 Jan 27, 2026
8494756
fix: update ui-package version to 1.5.9 in package.json
malav2110 Jan 27, 2026
d84fcd3
fix(ui): adjust sidebar styles for improved layout and scrolling beha…
malav2110 Jan 28, 2026
5502c79
Merge branch 'nodejs:main' into fix-sidebar-scroll-last-item
malav2110 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@node-core/ui-components",
"version": "1.5.8",
"version": "1.5.9",
"type": "module",
"exports": {
"./*": [
Expand Down
3 changes: 2 additions & 1 deletion packages/ui-components/src/Containers/Article/index.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
@apply [grid-area:sidebar]
lg:sticky
lg:top-0
lg:h-[100vh]
lg:max-h-screen
lg:self-stretch
lg:overflow-y-auto;
}

Expand Down
1 change: 1 addition & 0 deletions packages/ui-components/src/Containers/Sidebar/index.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
py-6
sm:overflow-auto
sm:border-r
sm:pb-16
Copy link
Member

@ovflowd ovflowd Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Padding could probably be a bit smaller.

Copy link
Contributor Author

@malav2110 malav2110 Jan 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With pb-14, the last item on the list is barely visible thus added pb-16.

Screenshot 2026-01-28 at 3 50 34 PM

Copy link
Member

@ovflowd ovflowd Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that really the case? This is how much padding I see

image

Copy link
Member

@ovflowd ovflowd Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're probably referring to the padding when the footer isn't visible.

image

So this is probably not the place you want to change the padding.

Copy link
Member

@ovflowd ovflowd Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, if you see the beginning of the sidebar has the same margins/paddings no matter if the header is visible or not

image image

But the same isn't truthy for the end of the sidebar:

image image

So this means this place is probably not the right one to add padding. Or it must be a mix of two different places.

Copy link
Member

@ovflowd ovflowd Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird. the Metabar is also stick and doesn't have said issue, so I'm pretty sure the same can be accomplished to the Sidebar 🤔

Copy link
Contributor Author

@malav2110 malav2110 Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did review the MetaBar to compare.

It is also position: sticky with top: 0, but the key difference is that it does not have a height restriction or internal scrolling. Its content is short enough to fit naturally in the viewport.

The SideBar is different. On Learn page, it has many more items, so it needs max-height + overflow-y-auto to scroll internally.

That's where the issue comes from:
100vh uses the full viewport height, but when the NavBar (+ security banner) is visible, it takes up space at top. The Sidebar still assumes the full height, so the last item/s ends up getting clipped.

I tested both cases:

  • Without the height constraint -> everything is visible, but user do not see the internal scrollbar and have to scroll the whole page.
  • With the constraint -> internal scrolling works, last item gets cutoff when the NavBar is present.

Because the MetaBar rarely overflows, it avoids this edge case entirely.

Copy link
Member

@ovflowd ovflowd Feb 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is also position: sticky with top: 0, but the key difference is that it does not have a height restriction or internal scrolling. Its content is short enough to fit naturally in the viewport.

Unfortunately, you're wrong. Example: https://nodejs-api-docs-tooling.vercel.app/child_process.html / https://nodejs-api-docs-tooling.vercel.app/globals.html

Copy link
Member

@ovflowd ovflowd Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I would recommend to avoid making assumptions, if I tell you it is possible or something the contrary, then I'm pretty sure it is possible 😛)

Copy link
Member

@ovflowd ovflowd Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I just want to avoid giving you a solution plated, so you can try it yourself 👀)

md:max-w-xs
lg:px-6
dark:border-neutral-900
Expand Down
Loading