Conversation
Only render the navItems container when the array has items to prevent an empty padded container from creating unwanted space in the mobile navigation.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
Signed-off-by: Igor Rodrigues Machado <107290125+igorrm19@users.noreply.github.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Igor Rodrigues Machado <107290125+igorrm19@users.noreply.github.com>
Is this breaking the build with navItems?.length > 0 && Signed-off-by: Igor Rodrigues Machado <107290125+igorrm19@users.noreply.github.com>
Removed unnecessary blank line before the main navigation items div. Signed-off-by: Igor Rodrigues Machado <107290125+igorrm19@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8722 +/- ##
==========================================
- Coverage 75.10% 75.07% -0.04%
==========================================
Files 104 104
Lines 9162 9167 +5
Branches 315 316 +1
==========================================
+ Hits 6881 6882 +1
- Misses 2279 2283 +4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
@ovflowd Is there still a problem with this PR? It's extremely simple and the errors were fixed a long time ago. If you don't want people contributing to the project, just close it, because that's what it seems like. |
2 participants
Description
This PR fixes an issue where an unwanted empty space was rendered in the mobile navigation menu when the navigation bar did not contain any child elements. It resolves this by ensuring the
navItemscontainer is only rendered when thenavItemsarray has a length greater than zero.Validation
To verify this change, visually inspect the mobile navigation menu on a page or configuration where
navItemsis empty or not provided. The menu should no longer contain an empty padded area at the bottom.Related Issues
Fixes #8719
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.