CI: Adding CI to test old CPU for SIMD compatibility via SDE Emulation #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Will add the patch, in a different PR to keep the diff under control |
ngoldbaum
approved these changes
Jan 21, 2026
Member
ngoldbaum
left a comment
ngoldbaum
left a comment
There was a problem hiding this comment.
LGTM, if you feel like it you can probably avoid repeating yourself a bit, see comments.
.github/workflows/test_old_cpu.yml
Outdated
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| test_sandy_bridge: |
Member
There was a problem hiding this comment.
Only if you care to mess with it: I bet you can make a build matrix like:
strategy:
matrix:
build-arch: [
['sandy_bridge', 'Sandy Bridge (x86_64-v2)'],
['haswell', 'Haswell (x86_64-v3)'],
]
And then reduce the definition to use only one job definition and rely on the build matrix to generate the two almost-identical jobs.
.github/workflows/test_old_cpu.yml
Outdated
| run: | | ||
| pip install . --no-build-isolation -v | ||
| - name: Test import on Haswell (x86-64-v3) |
Member
There was a problem hiding this comment.
typo, it's x86_64 with an underscore.
Member
Author
|
Ah this matrix will cancel the v3 job if v2 got failed, let me search for a workaround if exists |
Member
Author
|
Cool, now it works |
Member
Author
|
Cool, merging this, this require some modifications for new commits in #62 so will do those changes there itself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow emulates the SandyBridge (x86-64-v2) and Haswell (x86-64-v3)
And similar to #56 we can reproduce the failure because of unrecognized instruction in SandyBridge