Draft
Conversation
- Added estate.property model - Implemented core fields (name, description, expected_price, etc.) - Applied required field constraints - Enabled ORM-based persistence Chapter 3
|
|
Clean up code and module metadata: - Remove trailing newline and blank line whitespace (W391, W293) - Add missing `author` and `license` in __manifest__.py This removes lint and module loading warnings.
vivah-odoo
changed the title
- Added ir.model.access.csv for estate.property - Configured basic CRUD permissions for internal users Chapter 4 - Security Intro
vivah-odoo
force-pushed
the
19.0-tutorial-vivah
branch
from
d2d43cc to
d6c591c
Compare
- Fixed COM819 lint error in __manifest__.py - Removed/adjusted trailing comma in data list for proper formatting
vivah-odoo
changed the title
- Define window action and menu structure to expose estate.property in the UI. - Connect menus with the action to allow access to list and form views. - Register XML view and menu files in the manifest for proper loading. - Configure default values using Odoo framework utilities. - Apply field attributes like readonly and copy=False for better data control. - Add active flag for visibility handling and state field for lifecycle management. Chapter-5
mash-odoo
requested changes
Apr 9, 2026
mash-odoo
left a comment
mash-odoo
left a comment
There was a problem hiding this comment.
Hello!
Thank you for your work.
Here are some few questions and suggestions.
Also please update your PR title
vivah-odoo
changed the title
vivah-odoo
changed the title
Apply changes based on PR review comments. - Refactored code to follow Odoo coding guidelines - Fixed linting and formatting issues - Improved model field definitions where required - Removed redundant or unnecessary code
Added list view for estate.property model. - Defined list view in estate_property_views.xml using <list> tag - Configured fields to be displayed in the list view - Added string attributes to model fields for proper labeling Chapter 6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chapter-5