#16: Properly check return type from safe_float()#17
Open
richardneish wants to merge 1 commit intoopen-notify:masterfrom
Open
#16: Properly check return type from safe_float()#17richardneish wants to merge 1 commit intoopen-notify:masterfrom
richardneish wants to merge 1 commit intoopen-notify:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I saw your API mentioned on HackerNews (https://news.ycombinator.com/item?id=15406963) - very cool.
However, I am in London, UK with a longtitude of close to 0, and I noticed the API does not work for longitude values of 0 (or latitude, or altitude).
Please take a look at the attached change, which seems to fix the issue.