add Resource getter to ExtendedOpenTelemetrySdk#7832
Draft
zeitlinger wants to merge 1 commit intoopen-telemetry:mainfrom
Draft
add Resource getter to ExtendedOpenTelemetrySdk#7832zeitlinger wants to merge 1 commit intoopen-telemetry:mainfrom
zeitlinger wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7832 +/- ##
============================================
- Coverage 90.11% 90.11% -0.01%
Complexity 7224 7224
============================================
Files 821 821
Lines 21809 21811 +2
Branches 2136 2136
============================================
+ Hits 19654 19655 +1
- Misses 1486 1487 +1
Partials 669 669 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@jack-berg wdyt? |
Member
|
Oof I want this but..
|
Member
Author
|
@jsuereth what do you think? Is it in line with entities to expose the resource in the extended otel instance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needed for open-telemetry/opentelemetry-java-contrib#2296 (comment)