Skip to content

Add PR size guidelines to CONTRIBUTING.md #4888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pmcollins wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add PR size guidelines to CONTRIBUTING.md #4888

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01941f2
Add PR size guidelines to CONTRIBUTING.md
pmcollins Jan 29, 2026
2486ed4
Address PR feedback
pmcollins Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,19 @@ file in the package it is testing. Make sure that the file name begins with

## Pull Requests

### How to Structure Pull Requests

Smaller PRs get merged faster, improve review quality, and reduce the risk of conflicts. Please keep PRs small and focused:

- **Aim for 500 lines or fewer** (excluding deletions, generated files, and test fixtures)
- **One change per PR** -- address a single bug fix, feature, or refactor

If your work requires more extensive changes, consider a series of small PRs instead. If you want the community to
understand how your small PR fits into the context of your larger change, consider putting the large change
in your personal fork and providing a link to it in your PR description. Regardless, strive to provide clear,
incremental value to the repository for every change you make, such that the repository is always in a functional,
coherent state.

Comment on lines +181 to +186
Copy link
Member

@emdneto emdneto Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If your work requires more extensive changes, consider a series of small PRs instead. If you want the community to
understand how your small PR fits into the context of your larger change, consider putting the large change
in your personal fork and providing a link to it in your PR description. Regardless, strive to provide clear,
incremental value to the repository for every change you make, such that the repository is always in a functional,
coherent state.
- If your work requires more extensive changes, consider a series of small PRs instead.
- If you want the community to
understand how your small PR fits into the context of your larger change, consider putting the large change
in your personal fork and providing a link to it in your PR description.
- Regardless, strive to provide clear,
incremental value to the repository for every change you make, such that the repository is always in a functional,
coherent state.

Maybe keep in bullets as well?

### How to Send Pull Requests

Everyone is welcome to contribute code to `opentelemetry-python` via GitHub
Expand Down
Loading