Fix #692 [Bug]: Passing invalid parameters to gemini throws Undefined…

[alxlab-zone66x]

… array key "choices" /www/htdocs/vendor/openai-php/client/src/Responses/Chat/CreateResponse.php 54

Change-Id: Ibbf64cc554ef68844fd8338583f3fc8ec5fde413

What:

• Bug Fix

Description:

Related:

Fix issue #692

[iBotPeaches]

Could you add a test to confirm this? I think the HttpTransporter tests is the area to make a formulated Gemini exception to confirm this.

[alxlab-zone66x]

Yeah sure. That would make sense.

[alxlab-zone66x]

Hmm for the ErrorException type what do you thing would be best? Google returns:

[[
            'error' => [
                'code' => 400,
                'message' => 'Invalid JSON payload received. Unknown name "ddd": Cannot find field.',
                'status' => 'INVALID_ARGUMENT',
                'details' => [
                    [
                        '@type' => 'type.googleapis.com/google.rpc.BadRequest',
                        'fieldViolations' => [
                            [
                                'description' => 'Invalid JSON payload received. Unknown name "ddd": Cannot find field.',
                            ],
                        ],
                    ],
                ],
            ],
        ]]

type.googleapis.com/google.rpc.BadRequest would be more in line with OpenAI's type invalid_request_error, but INVALID_ARGUMENT is more informative imho.

[iBotPeaches]

type.googleapis.com/google.rpc.BadRequest would be more in line with OpenAI's type invalid_request_error, but INVALID_ARGUMENT is more informative imho.

Probably the message/status of the higher object. I think you can ignore inner details stuff.

[iBotPeaches]

This check is the only thing I'm iffy on right now. I'd rather the ErrorException class navigate the water of different error structures to normalize them. So the HTTPTransporter isn't required to formulate things perfectly for an exception class.

[krowinski]

Hi! Any update on this? Maybe Google should fix it ? I suppose every SDK has issues with error payloads ?

[iBotPeaches]

I wish Google would fix it. If you are making a parity API for OpenAI, at least make it match. My last comment is still outstanding.