fix: tolerate post-completion stream events in ResponseAccumulator#719
Open
zklapow wants to merge 1 commit intoopenai:mainfrom
Open
fix: tolerate post-completion stream events in ResponseAccumulator#719zklapow wants to merge 1 commit intoopenai:mainfrom
zklapow wants to merge 1 commit intoopenai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Responses API sends
response.rate_limits.updatedevents after the terminalresponse.completedevent.ResponseAccumulator.accumulate()throwsIllegalStateException("Response has already been completed.")on any event received after a terminal event, which crashes callers that pass every streamed event through it.This replaces the hard
checkwith an earlyreturnso post-completion events are silently ignored and the accumulated response remains intact.Reproduction
The stream ends with:
Passing these events to
ResponseAccumulatorthrows:Test plan
accumulateAfterCompletedtest to assert post-completion events are ignored rather than throwingResponseAccumulatorTesttests pass