fix: raise ContentFilterFinishReasonError on refusal responses#2847
Open
danylokv-lang wants to merge 1 commit intoopenai:mainfrom
Open
fix: raise ContentFilterFinishReasonError on refusal responses#2847danylokv-lang wants to merge 1 commit intoopenai:mainfrom
danylokv-lang wants to merge 1 commit intoopenai:mainfrom
Conversation
When responses.parse() receives a refusal response from the model (e.g., due to content moderation), it now raises ContentFilterFinishReasonError instead of letting the refusal text pass through to Pydantic validation, which would result in a confusing pydantic_core.ValidationError. This makes the behavior consistent with chat completions parsing, which already handles refusals properly. Fixes openai#2834
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes parsing error where refusal responses caused a confusing pydantic_core.ValidationError instead of a proper SDK exception.
Problem
When content moderation is triggered, the model returns a plain-text refusal like "I'm sorry, but I cannot assist with that request." instead of valid JSON. This refusal text was passed directly to Pydantic validation:
Since refusal text is not valid JSON, users received a low-level pydantic_core.ValidationError with no indication that the issue was content moderation.
Solution
Added a guard to detect refusal content before attempting Pydantic validation:
This is consistent with how refusals are handled in _completions.py (line 102).
Changes
_responses.py: Added refusal detection that raises ContentFilterFinishReasonError
Test Plan
✅ Static analysis passes (no errors)
✅ Logic now surfaces moderation-triggered responses as ContentFilterFinishReasonError
✅ Consistent with chat completions refusal handling
Fixes #2834