[Repo Assist] test: add MenuSizingHelper unit tests + ShellQuoting edge cases#142
Draft
github-actions[bot] wants to merge 1 commit intomasterfrom
Draft
Conversation
Add dedicated MenuSizingHelperTests.cs covering all edge cases for CalculateWindowHeight and ConvertPixelsToViewUnits: - zero/negative pixel inputs - zero DPI fallback to 96 - DPI scaling (96, 120, 144, 192) - minimum height enforcement and clamping - negative/zero work area handling - minimum larger than work area Extend ShellQuotingTests with previously untested metacharacters (], }, )), newline/carriage-return chars, and FormatExecCommand with single and empty argument arrays. Tray tests: 99 → 120 passed Shared tests: 525 → 531 passed (551 total, 20 skipped) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Adds dedicated unit tests for
MenuSizingHelperand extendsShellQuotingTestswith previously uncovered edge cases.MenuSizingHelperTests(new file — 21 tests)MenuSizingHelperwas used in integration-style scenarios insideMenuPositionerTests, but had no dedicated unit tests. The new class covers all documented edge cases for both methods:ConvertPixelsToViewUnitsCalculateWindowHeightminimumHeight < 1→ forced to 1max(content, minimum)minimumHeight > workAreaHeight→ clamped to work areaShellQuotingTests(6 additional cases)Previously untested metacharacters and scenarios:
],},)→NeedsQuotingreturnstrue\n) and carriage-return (\r) →NeedsQuotingreturnstrueFormatExecCommandwith a single argumentFormatExecCommandwith an empty array → returns""Test Status
OpenClaw.Tray.TestsOpenClaw.Shared.TestsAll tests pass. No production code was modified.