[Repo Assist] fix: ClassifyByKeywords recognises CI/CD patterns (ci/ prefix)#147
Draft
github-actions[bot] wants to merge 1 commit intomasterfrom
Draft
Conversation
'CI/CD pipeline completed' was not classified as build because ClassifyByKeywords only checked for 'ci ' (trailing space), missing the 'CI/CD' style where a slash follows 'CI'. Adding the 'ci/' check catches: - 'CI/CD pipeline completed' - 'CI/CD workflow triggered' - Any pattern where 'CI' is immediately followed by a slash False-positive analysis: common English words containing 'ci' (recipe, social, special, facial...) are followed by letters, not '/', so the new check introduces no false matches. Regression tests: two new InlineData entries in KeywordFallback_BackwardCompatible. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
NotificationCategorizer.ClassifyByKeywordschecked for"ci "(trailing space) to detect CI-related build notifications, but missed the common "CI/CD" pattern whereCIis immediately followed by a slash.Root Cause
A message like
"CI/CD pipeline completed"contains"ci/"but not"ci ", so it fell through to the default"info"category instead of"build".Fix
False-positive analysis: Common English words containing
ci—recipe,social,special,facial,official— are never followed by/in normal usage, so the new check introduces no false matches.Priority note: The keyword fallback is the last-resort path. Structured metadata (
Intent/Channel) takes priority and is unaffected. The fix only improves backwards-compatible plain-text message classification.Regression Tests
Two new
InlineDataentries added toKeywordFallback_BackwardCompatible:"CI/CD pipeline completed"→"build""CI/CD workflow triggered"→"build"Test Status
OpenClaw.Shared.TestsOpenClaw.Tray.TestsAll tests pass. Only
NotificationCategorizer.cs(production) andNotificationCategorizerTests.cs(test) were modified.