ci: check version placeholder in release PR#2257
Open
individual-it wants to merge 1 commit intomainfrom
Open
Conversation
ed89a7f to
be5d504
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Doing the check whether there are still version placeholders on the tag is too late. So I'm proposing to do this check in the release PR of ready-release-go.
That way the PR cannot be merged and a release created when there are still placeholders
Related Issue
Motivation and Context
Block the release as long as there are still placeholders in the code
How Has This Been Tested?
wccsScreenshots (if appropriate):
Types of changes
Checklist: