Skip to content

chore: remove spotless check override for Java 25#287

Merged
SoulPancake merged 1 commit intomainfrom
chore/remove-spotless-override-java25
Feb 13, 2026
Merged

chore: remove spotless check override for Java 25#287
SoulPancake merged 1 commit intomainfrom
chore/remove-spotless-override-java25

Conversation

@curfew-marathon
Copy link
Contributor

@curfew-marathon curfew-marathon commented Feb 12, 2026

Removes the spotless check override for Java 25 in the CI workflow. Previously, Java 25 builds were skipping spotlessCheck and only running build test-integration. This change ensures all Java versions (17, 21, 25) run the full build process consistently, including code formatting checks.

Summary by CodeRabbit

  • Chores
    • Simplified the build and test pipeline by consolidating the integration workflow, removing version-specific conditional logic for more consistent and streamlined execution.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 12, 2026

Walkthrough

The .github/workflows/main.yaml CI workflow was simplified to unconditionally run ./gradlew build test-integration, removing the Java 25-specific conditional that previously skipped the Spotless check task on that version.

Changes

Cohort / File(s) Summary
CI Workflow Simplification
.github/workflows/main.yaml
Removed Java 25-specific conditional logic that excluded spotlessCheck, replacing it with a single unconditional Gradle command that consistently runs build and integration tests across all Java versions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • jimmyjames
  • ewanharris
  • rhamzeh
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing a spotless check override for Java 25 in CI workflow, which aligns with the changeset that simplifies the build process by eliminating conditional logic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/remove-spotless-override-java25

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.70%. Comparing base (29c11aa) to head (925028e).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #287   +/-   ##
=========================================
  Coverage     37.70%   37.70%           
  Complexity     1236     1236           
=========================================
  Files           197      197           
  Lines          7609     7609           
  Branches        880      880           
=========================================
  Hits           2869     2869           
  Misses         4601     4601           
  Partials        139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@curfew-marathon curfew-marathon marked this pull request as ready for review February 12, 2026 23:02
@curfew-marathon curfew-marathon requested a review from a team as a code owner February 12, 2026 23:02
Copilot AI review requested due to automatic review settings February 12, 2026 23:02
@dosubot
Copy link

dosubot bot commented Feb 12, 2026

Related Documentation

Checked 8 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the main CI workflow to run the same Gradle task set across all Java versions in the test matrix, removing the special-casing that skipped spotlessCheck on Java 25.

Changes:

  • Removed the Java 25 conditional that excluded spotlessCheck.
  • Standardized the CI Gradle invocation to ./gradlew build test-integration for Java 17/21/25.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SoulPancake SoulPancake added this pull request to the merge queue Feb 13, 2026
Merged via the queue into main with commit d4b4f73 Feb 13, 2026
30 checks passed
@SoulPancake SoulPancake deleted the chore/remove-spotless-override-java25 branch February 13, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants