OCPEDGE-2276: Add TNA arbiter topology support to kcli deployment + general improvements

[vimauro]

Summary

• Add TNA (Two-Node with Arbiter) topology support to kcli deployment method, enabling arbiter-kcli deployments alongside existing fencing-kcli
• Consolidate four separate deployment scripts (deploy-arbiter-ipi.sh, deploy-arbiter-agent.sh, deploy-fencing-ipi.sh, deploy-fencing-agent.sh) into a single unified deploy-cluster.sh script with --topology and --method arguments
• Add new Makefile targets arbiter-kcli and fencing-kcli for kcli-based deployments
• Improved AWS hypervisor creation with duplicate stack detection and retry logic for ssh-keyscan
• Add Makefile validation for cluster types with helpful error messages for invalid input (made a mistake couple of times and realized 15 minutes later :D )

Note:

• We need to wait for kcli PR Added support for TNA platform karmab/kcli#850 to be merged before this is going to work for arbiter-kcli topology

[openshift-ci-robot]

@vimauro: This pull request references OCPEDGE-2276 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

• Add TNA (Two-Node with Arbiter) topology support to kcli deployment method, enabling arbiter-kcli deployments alongside existing fencing-kcli
• Consolidate four separate deployment scripts (deploy-arbiter-ipi.sh, deploy-arbiter-agent.sh, deploy-fencing-ipi.sh, deploy-fencing-agent.sh) into a single unified deploy-cluster.sh script with --topology and --method arguments
• Add new Makefile targets arbiter-kcli and fencing-kcli for kcli-based deployments
• Improved AWS hypervisor creation with duplicate stack detection and retry logic for ssh-keyscan
• Add Makefile validation for cluster types with helpful error messages for invalid input (made a mistake couple of times and realized 15 minutes later :D )

Note:

• We need to wait for kcli PR Added support for TNA platform karmab/kcli#850 to be merged before this is going to work for arbiter-kcli topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vimauro]

/hold

[fonta-rh]

Great addition! Added a few considerations. Specially the random-suffix for CloudFormation stack seems a bit dangerous to me, I'd like to hear more about the need for that

[fonta-rh]

Awesome work cleaning up at the same time new features are added. I think you might need a rebase because a couple PRs merged this morning, I'll re-lgtm after that

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fonta-rh, vimauro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [fonta-rh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vimauro]

/unhold