Skip to content

[nodesets] Fix incorrect ocp 4.20 labels#3762

Closed
michburk wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
michburk:nodesets-fix
Closed

[nodesets] Fix incorrect ocp 4.20 labels#3762
michburk wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
michburk:nodesets-fix

Conversation

@michburk
Copy link
Copy Markdown
Contributor

The bump from crc running ocp 4.20.1 to 4.20.14 got rolled back, but the labels + nodesets were not adjusted in response. Trying to request any nodesets that used a 4-20-14 label would fail, as they don't exist. 4-20-1 labels do exist.
This patch fixes the labels + naming.

See https://softwarefactory-project.io/zuul/t/rdoproject.org/labels

The bump from crc running ocp `4.20.1` to `4.20.14` got rolled back,
but the labels + nodesets were not adjusted in response.
Trying to request any nodesets that used a 4-20-14 label would fail,
as they don't exist. 4-20-1 labels do exist.
This patch fixes the labels + naming.

Signed-off-by: Michael Burke <michburk@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 12, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 12, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign michburk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michburk michburk mentioned this pull request Mar 16, 2026
@michburk
Copy link
Copy Markdown
Contributor Author

michburk commented Mar 16, 2026

I just did some testing with pr #3768

Tried switching the cifmw-base-multinode-kuttl job to use centos-9-medium-crc-cloud-ocp-4-20-14-3xl and the job cifmw-multinode-kuttl got NODE_FAILURE

then added this pr as a Depends-On: and changed the job to use centos-9-medium-crc-cloud-ocp-4-20-1-3xl and cifmw-base-multinode-kuttl is progressing as expected with the crc-cloud-ocp-4-20-1-3xl label on the crc node.

@michburk michburk marked this pull request as ready for review March 16, 2026 13:16
@michburk michburk requested a review from a team March 16, 2026 14:49
@danpawlik
Copy link
Copy Markdown
Contributor

@michburk IMHO instead of doing such change, we should revert - 25d1c96ce

In commit message you can put:
The dedicated image 4.20.14 has been lost from the builder host. It would also not solve the CA certificate issue, because other images are also affected by the issue.

@danpawlik
Copy link
Copy Markdown
Contributor

done in: #3771
Thanks @michburk for reminder!

@danpawlik danpawlik closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants