Skip to content

Fix Resurrect Achievement Items #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dlglin wants to merge 9 commits into
base: WeBWorK-2.21
Choose a base branch
from
Open

Fix Resurrect Achievement Items #2938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7d7fd79
Fix ressurect achievement items
dlglin Feb 13, 2026
68f98e2
Fix resurrect achievement items
dlglin Mar 26, 2026
2a4996a
fix resurrect achievement items
dlglin Mar 26, 2026
1ccb538
Fix maketext call
dlglin Mar 26, 2026
34bfbe6
Add controller object to can_use
dlglin Apr 13, 2026
fa2fa2f
Merge branch 'WeBWorK-2.21' into fix-resurrect
dlglin Apr 13, 2026
f7a5a94
Update lib/WeBWorK/AchievementItems/ResurrectHW.pm
dlglin Apr 14, 2026
447cecb
Update lib/WeBWorK/AchievementItems/ResurrectHW.pm
dlglin Apr 14, 2026
25c9dc6
Update lib/WeBWorK/AchievementItems/ResurrectGW.pm
dlglin Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/WeBWorK/AchievementItems.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ sub UserItems ($c, $userName, $set, $records) {
push(@items, $achievementItem);
next;
}
next unless $achievementItem->can_use($set, $records);
next unless $achievementItem->can_use($set, $records, $c);

# Use the achievement item.
if ($use_item_id eq $item) {
Expand All @@ -104,7 +104,7 @@ sub UserItems ($c, $userName, $set, $records) {
my @new_items;
for (@items) {
my $item = $_->[0];
next unless $item->{count} && $item->can_use($set, $records);
next unless $item->{count} && $item->can_use($set, $records, $c);
push(@new_items, [ $item, $item->print_form($set, $records, $c) ]);
}
return \@new_items;
Expand Down
2 changes: 1 addition & 1 deletion lib/WeBWorK/AchievementItems/AddNewTestGW.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ sub new ($class) {
}, $class;
}

sub can_use ($self, $set, $records) {
sub can_use ($self, $set, $records, $c) {
return
$set->assignment_type =~ /gateway/
&& $set->set_id !~ /,v\d+$/
Expand Down
2 changes: 1 addition & 1 deletion lib/WeBWorK/AchievementItems/DoubleProb.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ sub new ($class) {
}, $class;
}

sub can_use ($self, $set, $records) {
sub can_use ($self, $set, $records, $c) {
return $set->assignment_type eq 'default' && after($set->open_date);
}

Expand Down
2 changes: 1 addition & 1 deletion lib/WeBWorK/AchievementItems/DoubleSet.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ sub new ($class) {
}, $class;
}

sub can_use ($self, $set, $records) {
sub can_use ($self, $set, $records, $c) {
return $set->assignment_type eq 'default' && after($set->open_date);
}

Expand Down
2 changes: 1 addition & 1 deletion lib/WeBWorK/AchievementItems/DuplicateProb.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ sub new ($class) {
}, $class;
}

sub can_use ($self, $set, $records) {
sub can_use ($self, $set, $records, $c) {
return $set->assignment_type eq 'default' && between($set->open_date, $set->due_date);
}

Expand Down
2 changes: 1 addition & 1 deletion lib/WeBWorK/AchievementItems/ExtendDueDate.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ sub new ($class) {
}, $class;
}

sub can_use ($self, $set, $records) {
sub can_use ($self, $set, $records, $c) {
return $set->assignment_type eq 'default' && between($set->open_date, $set->due_date + ONE_DAY);
}

Expand Down
2 changes: 1 addition & 1 deletion lib/WeBWorK/AchievementItems/ExtendDueDateGW.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ sub new ($class) {
}, $class;
}

sub can_use ($self, $set, $records) {
sub can_use ($self, $set, $records, $c) {
return
$set->assignment_type =~ /gateway/
&& $set->set_id !~ /,v\d+$/
Expand Down
3 changes: 2 additions & 1 deletion lib/WeBWorK/AchievementItems/ExtendReducedDate.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,10 @@ sub new ($class) {
}, $class;
}

sub can_use ($self, $set, $records) {
sub can_use ($self, $set, $records, $c) {
return 0
unless $set->assignment_type eq 'default'
&& $c->ce->{pg}{ansEvalDefaults}{enableReducedScoring}
&& $set->enable_reduced_scoring
&& $set->reduced_scoring_date
&& $set->reduced_scoring_date < $set->due_date;
Expand Down
2 changes: 1 addition & 1 deletion lib/WeBWorK/AchievementItems/FullCreditProb.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ sub new ($class) {
}, $class;
}

sub can_use ($self, $set, $records) {
sub can_use ($self, $set, $records, $c) {
return 0
unless $set->assignment_type eq 'default'
&& after($set->open_date);
Expand Down
2 changes: 1 addition & 1 deletion lib/WeBWorK/AchievementItems/FullCreditSet.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ sub new ($class) {
}, $class;
}

sub can_use ($self, $set, $records) {
sub can_use ($self, $set, $records, $c) {
return 0
unless $set->assignment_type eq 'default'
&& after($set->open_date);
Expand Down
2 changes: 1 addition & 1 deletion lib/WeBWorK/AchievementItems/HalfCreditProb.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ sub new ($class) {
}, $class;
}

sub can_use ($self, $set, $records) {
sub can_use ($self, $set, $records, $c) {
return 0
unless $set->assignment_type eq 'default'
&& after($set->open_date);
Expand Down
2 changes: 1 addition & 1 deletion lib/WeBWorK/AchievementItems/HalfCreditSet.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ sub new ($class) {
}, $class;
}

sub can_use ($self, $set, $records) {
sub can_use ($self, $set, $records, $c) {
return 0
unless $set->assignment_type eq 'default'
&& after($set->open_date);
Expand Down
3 changes: 2 additions & 1 deletion lib/WeBWorK/AchievementItems/NoReducedCred.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@ sub new ($class) {
}, $class;
}

sub can_use ($self, $set, $records) {
sub can_use ($self, $set, $records, $c) {
return
$set->assignment_type eq 'default'
&& $c->ce->{pg}{ansEvalDefaults}{enableReducedScoring}
&& $set->enable_reduced_scoring
&& $set->reduced_scoring_date
&& $set->reduced_scoring_date < $set->due_date
Expand Down
2 changes: 1 addition & 1 deletion lib/WeBWorK/AchievementItems/ReducedCred.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ sub new ($class) {
}, $class;
}

sub can_use ($self, $set, $records) {
sub can_use ($self, $set, $records, $c) {
return $set->assignment_type eq 'default' && between($set->open_date, $set->due_date + ONE_DAY);
}

Expand Down
2 changes: 1 addition & 1 deletion lib/WeBWorK/AchievementItems/ResetIncorrectAttempts.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ sub new ($class) {
}, $class;
}

sub can_use ($self, $set, $records) {
sub can_use ($self, $set, $records, $c) {
return 0
unless $set->assignment_type eq 'default'
&& between($set->open_date, $set->due_date);
Expand Down
103 changes: 83 additions & 20 deletions lib/WeBWorK/AchievementItems/ResurrectGW.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,74 @@ sub new ($class) {
id => 'ResurrectGW',
name => x('Necromancers Charm'),
description => x(
'Reopens any test for an additional 24 hours. This allows you to take a test even if the '
. 'close date has past. This item does not allow you to take additional versions of the test.'
'Reopens any test for an additional 24 hours. If you are allowed to start new versions of the test, '
. 'then this allows you to start a new test even if the close date has past. '
. 'If you were not allowed to start a new version of the test, '
. 'then this item will not allow you to take additional versions of the test. '
. 'This item will not extend the time limit for any tests that you have already started.'
)
}, $class;
}

sub can_use ($self, $set, $records) {
sub can_use ($self, $set, $records, $c) {
return $set->assignment_type =~ /gateway/
&& (after($set->due_date) || ($set->reduced_scoring_date && after($set->reduced_scoring_date)));
&& (
after($set->due_date)
|| ($c->ce->{pg}{ansEvalDefaults}{enableReducedScoring}
&& $set->enable_reduced_scoring
&& after($set->reduced_scoring_date))
);
# TODO: Check if a new version can be created, and only allow using this reward in that case.
}

sub print_form ($self, $set, $records, $c) {
return $c->tag(
'p',
$c->maketext(
'Reopen this test for the next 24 hours. This item does not allow you to take any additional '
. 'versions of the test.'
)
);
if (after($set->due_date)) {
return $c->tag(
'p',
$c->maketext(
'Reopen this test for the next 24 hours. If you were allowed to start new versions of the test, '
. 'then this will allow you to start a new test. '
. 'If you have already started all of the versions of the test that you are allowed to start, '
. 'then you should not use this item. '
. 'This item will not extend the time limit for any tests that you have already started.'
)
);
} else {
if (after($set->due_date - ONE_DAY)) {
return $c->tag(
'p',
$c->maketext(
'Reopen this test for full credit for the next 24 hours. If you are allowed to start new versions '
. 'of the test, then this will allow you to start a new test. '
. 'If you have already started all of the versions of the test that you are allowed to start, '
. 'then you should not use this item. '
. 'This item will not extend the time limit for any tests that you have already started.'
)
);
} else {
return $c->c(
$c->tag(
'p',
$c->maketext(
'Reopen this test for full credit for the next 24 hours. After 24 hours any tests will revert '
. 'to counting for [_1]% of their value until [_2].',
$c->ce->{pg}{ansEvalDefaults}{reducedScoringValue} * 100,
$c->formatDateTime($set->due_date, $c->ce->{studentDateDisplayFormat})
)
),
$c->tag(
'p',
$c->maketext(
' If you are allowed to start new versions of the test, '
. 'then this will allow you to start a new test. '
. 'If you have already started all of the versions of the test that you are allowed to start, '
. 'then you should not use this item. '
. 'This item will not extend the time limit for any tests that you have already started.'
)
)
)->join('');
}
}
}

sub use_item ($self, $set, $records, $c) {
Expand All @@ -44,18 +92,33 @@ sub use_item ($self, $set, $records, $c) {
$set->reduced_scoring_date(time + ONE_DAY);
$userSet->reduced_scoring_date($set->reduced_scoring_date);
}
$set->due_date(time + ONE_DAY);
$userSet->due_date($set->due_date);
if ($set->due_date > $set->answer_date) {
$set->answer_date(time + ONE_DAY);
$userSet->answer_date($set->answer_date);
if (after($set->due_date - ONE_DAY)) {
$set->due_date(time + ONE_DAY);
$userSet->due_date($set->due_date);
if ($set->due_date > $set->answer_date) {
$set->answer_date($set->due_date);
$userSet->answer_date($set->answer_date);
}
}
$db->putUserSet($userSet);

return $c->maketext(
'This assignment has been reopened and will now close on [_1].',
$c->formatDateTime($set->due_date, $c->ce->{studentDateDisplayFormat})
);
if ($c->ce->{pg}{ansEvalDefaults}{enableReducedScoring}
&& $set->enable_reduced_scoring
&& ($set->reduced_scoring_date != $set->due_date))
{
return $c->maketext(
'This assignment has been reopened and is due on [_1]. After that date any work '
. 'completed will count for [_2]% of its value until [_3].',
$c->formatDateTime($set->reduced_scoring_date, $c->ce->{studentDateDisplayFormat}),
$c->ce->{pg}{ansEvalDefaults}{reducedScoringValue} * 100,
$c->formatDateTime($set->due_date, $c->ce->{studentDateDisplayFormat})
);
Comment thread
dlglin marked this conversation as resolved.
} else {
return $c->maketext(
'This assignment has been reopened and will now close on [_1].',
$c->formatDateTime($set->due_date, $c->ce->{studentDateDisplayFormat})
);
}
}

1;
96 changes: 71 additions & 25 deletions lib/WeBWorK/AchievementItems/ResurrectHW.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,48 +16,94 @@ sub new ($class) {
}, $class;
}

sub can_use ($self, $set, $records) {
sub can_use ($self, $set, $records, $c) {
return $set->assignment_type eq 'default'
&& (after($set->due_date) || ($set->reduced_scoring_date && after($set->reduced_scoring_date)));
&& (
after($set->due_date)
|| ($c->ce->{pg}{ansEvalDefaults}{enableReducedScoring}
&& $set->enable_reduced_scoring
&& after($set->reduced_scoring_date))
);
}

sub print_form ($self, $set, $records, $c) {
return $c->tag('p',
$c->maketext('Reopen this homework assignment for the next 24 hours. All problems will be rerandomized.'));
if (after($set->due_date)) {
return $c->tag(
'p',
$c->maketext(
'Reopen this homework assignment for the next 24 hours. All problems will be rerandomized.')
);
} else {
if (after($set->due_date - ONE_DAY)) {
return $c->tag('p',
$c->maketext('Reopen this homework assignment for full credit for the next 24 hours. '));
} else {
return $c->tag(
'p',
$c->maketext(
'Reopen this homework assignment for full credit for the next 24 hours. After 24 hours '
. 'any progress will revert to counting for [_1]% of the value until [_2].',
$c->ce->{pg}{ansEvalDefaults}{reducedScoringValue} * 100,
$c->formatDateTime($set->due_date, $c->ce->{studentDateDisplayFormat})
)
);
}
}
}

sub use_item ($self, $set, $records, $c) {
my $db = $c->db;
my $userSet = $db->getUserSet($set->user_id, $set->set_id);

# Change the seed for all of the problems since the set is currently closed.
my %userProblems =
map { $_->problem_id => $_ } $db->getUserProblemsWhere({ user_id => $set->user_id, set_id => $set->set_id });
for my $problem (@$records) {
my $userProblem = $userProblems{ $problem->problem_id };
$userProblem->problem_seed($userProblem->problem_seed % 2**31 + 1);
$problem->problem_seed($userProblem->problem_seed);
$db->putUserProblem($userProblem);
my $db = $c->db;
my $userSet = $db->getUserSet($set->user_id, $set->set_id);
my $rerandomizeMessage = '';

# Change the seed for all of the problems if the set is currently closed.
if (after($set->due_date)) {
my %userProblems =
map { $_->problem_id => $_ }
$db->getUserProblemsWhere({ user_id => $set->user_id, set_id => $set->set_id });
for my $problem (@$records) {
my $userProblem = $userProblems{ $problem->problem_id };
$userProblem->problem_seed($userProblem->problem_seed % 2**31 + 1);
$problem->problem_seed($userProblem->problem_seed);
Copy link
Copy Markdown
Member

@drgrice1 drgrice1 Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this re-randomization should only occur if it is also past the answer date. Is there any need for this if the answer date has not passed?

Copy link
Copy Markdown
Member Author

@dlglin dlglin Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case where there are limited attempts allowed on a problem a student could check their answers as many times as they want to find the correct answers, and then resurrect the set and enter the correct answers using only one attempt.

Copy link
Copy Markdown
Member

@drgrice1 drgrice1 Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, I forgot about the fact that once the set is closed the student can still use the "Check Answers" button, and thus can do what you say.

$db->putUserProblem($userProblem);
}
$rerandomizeMessage = $c->maketext('Problems have been rerandomized.');
}

# Add time to the reduced scoring date if it was defined in the first place
if ($set->reduced_scoring_date) {
$set->reduced_scoring_date(time + ONE_DAY);
$userSet->reduced_scoring_date($set->reduced_scoring_date);
}
# Add time to the close date
$set->due_date(time + ONE_DAY);
$userSet->due_date($set->due_date);
# This may require also extending the answer date.
if ($set->due_date > $set->answer_date) {
$set->answer_date($set->due_date);
$userSet->answer_date($set->answer_date);
# Add time to the close date if necessary
if (after($set->due_date - ONE_DAY)) {
$set->due_date(time + ONE_DAY);
$userSet->due_date($set->due_date);
# This may require also extending the answer date.
if ($set->due_date > $set->answer_date) {
$set->answer_date($set->due_date);
$userSet->answer_date($set->answer_date);
}
}
$db->putUserSet($userSet);

return $c->maketext(
'This assignment has been reopened and will now close on [_1]. Problems have been rerandomized.',
$c->formatDateTime($set->due_date, $c->ce->{studentDateDisplayFormat}));
if ($c->ce->{pg}{ansEvalDefaults}{enableReducedScoring}
&& $set->enable_reduced_scoring
&& ($set->reduced_scoring_date != $set->due_date))
{
return $c->maketext(
'This assignment has been reopened and is due on [_1]. After that date any work '
. 'completed will count for [_2]% of its value until [_3].',
$c->formatDateTime($set->reduced_scoring_date, $c->ce->{studentDateDisplayFormat}),
$c->ce->{pg}{ansEvalDefaults}{reducedScoringValue} * 100,
$c->formatDateTime($set->due_date, $c->ce->{studentDateDisplayFormat})
) . ($rerandomizeMessage ? " $rerandomizeMessage" : '');
} else {
return $c->maketext(
'This assignment has been reopened and will now close on [_1].',
$c->formatDateTime($set->due_date, $c->ce->{studentDateDisplayFormat})
) . ($rerandomizeMessage ? " $rerandomizeMessage" : '');
}
}

1;
Loading
Loading