improve: prepare for removal of exitOnStopLeading from public API#3161
Merged
improve: prepare for removal of exitOnStopLeading from public API#3161
Conversation
csviri
approved these changes
Feb 6, 2026
Collaborator
csviri
left a comment
csviri
left a comment
There was a problem hiding this comment.
Just comment regarding one minor details, otherwise looks awesome, thank you!
|
|
||
| /** | ||
| * @deprecated Use {@link LeaderElectionConfigurationBuilder} instead | ||
| */ |
Collaborator
There was a problem hiding this comment.
Please add proper annotation not just javadoc
Collaborator
|
The test failures are not releated, but we have to check on those later |
Signed-off-by: Chris Laprun <metacosm@gmail.com>
csviri
force-pushed
the
leader-election
branch
from
be2705f to
4404e24
Compare
[skip ci] Signed-off-by: Chris Laprun <metacosm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Laprun metacosm@gmail.com