Skip to content

[WIP] feat: allow transform resource before caching in TemporaryResoureCache #3215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
csviri wants to merge 1 commit into
base: next
Choose a base branch
from
+9 −1
Draft

[WIP] feat: allow transform resource before caching in TemporaryResoureCache #3215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .../io/javaoperatorsdk/operator/processing/event/source/informer/TemporaryResourceCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import java.util.Map;
import java.util.Optional;
import java.util.concurrent.ConcurrentHashMap;
import java.util.function.UnaryOperator;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand Down Expand Up @@ -60,6 +61,7 @@ public class TemporaryResourceCache<T extends HasMetadata> {
private String latestResourceVersion;

private final Map<ResourceID, EventFilterDetails> activeUpdates = new HashMap<>();
private final UnaryOperator<T> transformationFunction;

public enum EventHandling {
DEFER,
Expand All @@ -68,7 +70,13 @@ public enum EventHandling {
}

public TemporaryResourceCache(boolean comparableResourceVersions) {
this(comparableResourceVersions, t -> t);
}

public TemporaryResourceCache(
boolean comparableResourceVersions, UnaryOperator<T> transformationFunction) {
this.comparableResourceVersions = comparableResourceVersions;
this.transformationFunction = transformationFunction;
}

public synchronized void startEventFilteringModify(ResourceID resourceID) {
Expand Down Expand Up @@ -204,7 +212,7 @@ public synchronized void putResource(T newResource) {
"Temporarily moving ahead to target version {} for resource id: {}",
newResource.getMetadata().getResourceVersion(),
resourceId);
cache.put(resourceId, newResource);
cache.put(resourceId, transformationFunction.apply(newResource));
}
}

Expand Down
Loading