Skip to content

🌱 Add negative profile lookup test case#2633

Merged
openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
tmshort:add-negative-tls-profile-test
Apr 8, 2026
Merged

🌱 Add negative profile lookup test case#2633
openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
tmshort:add-negative-tls-profile-test

Conversation

@tmshort
Copy link
Copy Markdown
Contributor

@tmshort tmshort commented Apr 8, 2026

This restores the negative test that was removed in #2632

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Copilot AI review requested due to automatic review settings April 8, 2026 13:47
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 8, 2026

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit e904867
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/69d6632744dc180008c12399
😎 Deploy Preview https://deploy-preview-2633--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort tmshort changed the title :seedlling: Add negative profile lookup test case 🌱 Add negative profile lookup test case Apr 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores a negative test case for TLS profile lookup that was removed in PR #2632. The test verifies that looking up a non-existent profile returns an error, complementing the existing positive test cases in TestProfilesMapCompleteness.

Changes:

  • Add a negative test case in TestProfilesMapCompleteness to verify that looking up a non-existent profile returns an error

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.95%. Comparing base (8614e3b) to head (e904867).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2633      +/-   ##
==========================================
+ Coverage   68.93%   68.95%   +0.02%     
==========================================
  Files         139      139              
  Lines        9891     9891              
==========================================
+ Hits         6818     6820       +2     
+ Misses       2563     2562       -1     
+ Partials      510      509       -1     
Flag Coverage Δ
e2e 37.57% <ø> (+0.28%) ⬆️
experimental-e2e 52.25% <ø> (+0.04%) ⬆️
unit 53.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort force-pushed the add-negative-tls-profile-test branch from 3c95471 to e904867 Compare April 8, 2026 14:16
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 42f101e into operator-framework:main Apr 8, 2026
26 checks passed
@tmshort tmshort deleted the add-negative-tls-profile-test branch April 8, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants