Conversation
…s to throw exception if divisor is 0
| public class Division { | ||
|
|
||
| public static final long division(int a, int b) { | ||
|
|
There was a problem hiding this comment.
The method will throw an exception by ensuring the value of b before the result "long" is calculated avoiding unexpected results.
| int absA = Math.abs(a); | ||
| int absB = Math.abs(b); | ||
|
|
||
| if (b == 0) { |
There was a problem hiding this comment.
The method will throw an exception by ensuring the value of b before the result "long" is calculated avoiding unexpected results.
| int absA = Math.abs(a); | ||
| int absB = Math.abs(b); | ||
|
|
||
| if (b == 0) { |
There was a problem hiding this comment.
The method will throw an exception by ensuring the value of b before the result "long" is calculated avoiding unexpected results.
| int absA = Math.abs(a); | ||
| int absB = Math.abs(b); | ||
|
|
||
| if (b == 0) { |
There was a problem hiding this comment.
The method will throw an exception by ensuring the value of b before the result "long" is calculated avoiding unexpected results.
| int absB = Math.abs(b); | ||
| int tempA, tempB, counter; | ||
|
|
||
| if (b == 0) { |
There was a problem hiding this comment.
The method will throw an exception by ensuring the value of b before the result "long" is calculated avoiding unexpected results.
| public static final long divisionUsingLogs(int a, int b) { | ||
| long absA = Math.abs(a); | ||
| long absB = Math.abs(b); | ||
|
|
There was a problem hiding this comment.
The method will throw an exception by ensuring the value of b before the result "long" is calculated avoiding unexpected results.
Bourdeaa
left a comment
There was a problem hiding this comment.
Please note comments for each change in the PR
This feature adds illegalArgumentException handling for divisors of 0. This exception is thrown for each method regardless of how the division is obtained. The method of using Exceptions is useful as future development allows for change in the exception handling, futureproofing the code to change how we want to handle division by 0 errors.