add Type::isError method

phpstan-baseline.neon

@@ -1053,6 +1053,12 @@ parameters:
 			count: 2
 			path: src/Type/Enum/EnumCaseObjectType.php
 
+		-
+			rawMessage: 'Doing instanceof PHPStan\Type\ErrorType is error-prone and deprecated. Use Type::isError() instead.'
+			identifier: phpstanApi.instanceofType
+			count: 1
+			path: src/Type/ErrorType.php
+
 		-
 			rawMessage: 'Doing instanceof PHPStan\Type\ConstantScalarType is error-prone and deprecated. Use Type::isConstantScalarValue() or Type::getConstantScalarTypes() or Type::getConstantScalarValues() instead.'
 			identifier: phpstanApi.instanceofType

src/Analyser/MutatingScope.php

@@ -1323,15 +1323,15 @@
 
 			$returnType = $functionReflection->getReturnType();
 			$generatorSendType = $returnType->getTemplateType(Generator::class, 'TSend');
-			if ($generatorSendType instanceof ErrorType) {
+			if ($generatorSendType->isError()->yes()) {
 				return new MixedType();
 			}
 
 			return $generatorSendType;
 		} elseif ($node instanceof Expr\YieldFrom) {
 			$yieldFromType = $this->getType($node->expr);
 			$generatorReturnType = $yieldFromType->getTemplateType(Generator::class, 'TReturn');
-			if ($generatorReturnType instanceof ErrorType) {
+			if ($generatorReturnType->isError()->yes()) {
 				return new MixedType();
 			}
 

src/Analyser/Traverser/GenericTypeTemplateTraverser.php

@@ -2,7 +2,6 @@
 
 namespace PHPStan\Analyser\Traverser;
 
-use PHPStan\Type\ErrorType;
 use PHPStan\Type\Generic\TemplateType;
 use PHPStan\Type\Generic\TemplateTypeHelper;
 use PHPStan\Type\Generic\TemplateTypeMap;
@@ -25,7 +24,7 @@
 	{
 		if ($type instanceof TemplateType && !$type->isArgument()) {
 			$newType = $this->resolvedTemplateTypeMap->getType($type->getName());
-			if ($newType === null || $newType instanceof ErrorType) {
+			if ($newType === null || $newType->isError()->yes()) {
 				return $type->getDefault() ?? $type->getBound();
 			}
 

src/Reflection/ClassReflection.php

@@ -1666,7 +1666,7 @@
 		if ($resolved !== null) {
 			$templateTypeMap = $this->getTemplateTypeMap();
 			return $this->activeTemplateTypeMap = $resolved->map(static function (string $name, Type $type) use ($templateTypeMap): Type {
-				if ($type instanceof ErrorType) {
+				if ($type->isError()->yes()) {
 					$templateType = $templateTypeMap->getType($name);
 					if ($templateType !== null) {
 						return TemplateTypeHelper::resolveToDefaults($templateType);

src/Reflection/InitializerExprTypeResolver.php

@@ -518,10 +518,10 @@
 	{
 		$leftStringType = $left->toString();
 		$rightStringType = $right->toString();
 		if (TypeCombinator::union(
 			$leftStringType,
 			$rightStringType,
-		) instanceof ErrorType) {
+		)->isError()->yes()) {
 			return new ErrorType();
 		}
 
@@ -1020,7 +1020,7 @@
 		$leftNumberType = $leftType->toNumber();
 		$rightNumberType = $rightType->toNumber();
 
-		if ($leftNumberType instanceof ErrorType || $rightNumberType instanceof ErrorType) {
+		if ($leftNumberType->isError()->yes() || $rightNumberType->isError()->yes()) {
 			return new ErrorType();
 		}
 
@@ -1075,7 +1075,7 @@
 			return new ErrorType();
 		}
 
-		if ($leftType->toNumber() instanceof ErrorType || $rightType->toNumber() instanceof ErrorType) {
+		if (TypeCombinator::union($leftType->toNumber(), $rightType->toNumber())->isError()->yes()) {
 			return new ErrorType();
 		}
 
@@ -1136,7 +1136,7 @@
 					$leftNumberType = $leftTypeInner->toNumber();
 					$rightNumberType = $rightTypeInner->toNumber();
 
-					if ($leftNumberType instanceof ErrorType || $rightNumberType instanceof ErrorType) {
+					if ($leftNumberType->isError()->yes() || $rightNumberType->isError()->yes()) {
 						return new ErrorType();
 					}
 
@@ -1183,7 +1183,7 @@
 			return new ErrorType();
 		}
 
-		if ($leftType->toNumber() instanceof ErrorType || $rightType->toNumber() instanceof ErrorType) {
+		if (TypeCombinator::union($leftType->toNumber(), $rightType->toNumber())->isError()->yes()) {
 			return new ErrorType();
 		}
 
@@ -1254,7 +1254,7 @@
 						$leftNumberType = $leftTypeInner->toNumber();
 						$rightNumberType = $rightTypeInner->toNumber();
 
-						if ($leftNumberType instanceof ErrorType || $rightNumberType instanceof ErrorType) {
+						if ($leftNumberType->isError()->yes() || $rightNumberType->isError()->yes()) {
 							return new ErrorType();
 						}
 
@@ -1310,7 +1310,7 @@
 			return $extensionSpecified;
 		}
 
-		if ($leftType->toNumber() instanceof ErrorType || $rightType->toNumber() instanceof ErrorType) {
+		if ($leftType->toNumber()->isError()->yes() || $rightType->toNumber()->isError()->yes()) {
 			return new ErrorType();
 		}
 
@@ -1327,7 +1327,7 @@
 						$leftNumberType = $leftTypeInner->toNumber();
 						$rightNumberType = $rightTypeInner->toNumber();
 
-						if ($leftNumberType instanceof ErrorType || $rightNumberType instanceof ErrorType) {
+						if ($leftNumberType->isError()->yes() || $rightNumberType->isError()->yes()) {
 							return new ErrorType();
 						}
 
@@ -1431,7 +1431,7 @@
 						$leftNumberType = $leftTypeInner->toNumber();
 						$rightNumberType = $rightTypeInner->toNumber();
 
-						if ($leftNumberType instanceof ErrorType || $rightNumberType instanceof ErrorType) {
+						if ($leftNumberType->isError()->yes() || $rightNumberType->isError()->yes()) {
 							return new ErrorType();
 						}
 
@@ -1634,7 +1634,7 @@
 						$leftNumberType = $leftTypeInner->toNumber();
 						$rightNumberType = $rightTypeInner->toNumber();
 
-						if ($leftNumberType instanceof ErrorType || $rightNumberType instanceof ErrorType) {
+						if ($leftNumberType->isError()->yes() || $rightNumberType->isError()->yes()) {
 							return new ErrorType();
 						}
 
@@ -1683,7 +1683,7 @@
 						$leftNumberType = $leftTypeInner->toNumber();
 						$rightNumberType = $rightTypeInner->toNumber();
 
-						if ($leftNumberType instanceof ErrorType || $rightNumberType instanceof ErrorType) {
+						if ($leftNumberType->isError()->yes() || $rightNumberType->isError()->yes()) {
 							return new ErrorType();
 						}
 
@@ -1741,7 +1741,7 @@
 		}
 
 		$exponentiatedTyped = $leftType->exponentiate($rightType);
-		if (!$exponentiatedTyped instanceof ErrorType) {
+		if (!$exponentiatedTyped->isError()->yes()) {
 			return $exponentiatedTyped;
 		}
 
@@ -1778,7 +1778,7 @@
 						$leftNumberType = $leftTypeInner->toNumber();
 						$rightNumberType = $rightTypeInner->toNumber();
 
-						if ($leftNumberType instanceof ErrorType || $rightNumberType instanceof ErrorType) {
+						if ($leftNumberType->isError()->yes() || $rightNumberType->isError()->yes()) {
 							return new ErrorType();
 						}
 
@@ -1805,7 +1805,7 @@
 		$leftNumberType = $leftType->toNumber();
 		$rightNumberType = $rightType->toNumber();
 
-		if ($leftNumberType instanceof ErrorType || $rightNumberType instanceof ErrorType) {
+		if ($leftNumberType->isError()->yes() || $rightNumberType->isError()->yes()) {
 			return new ErrorType();
 		}
 
@@ -1842,7 +1842,7 @@
 						$leftNumberType = $leftTypeInner->toNumber();
 						$rightNumberType = $rightTypeInner->toNumber();
 
-						if ($leftNumberType instanceof ErrorType || $rightNumberType instanceof ErrorType) {
+						if ($leftNumberType->isError()->yes() || $rightNumberType->isError()->yes()) {
 							return new ErrorType();
 						}
 
@@ -1869,7 +1869,7 @@
 		$leftNumberType = $leftType->toNumber();
 		$rightNumberType = $rightType->toNumber();
 
-		if ($leftNumberType instanceof ErrorType || $rightNumberType instanceof ErrorType) {
+		if ($leftNumberType->isError()->yes() || $rightNumberType->isError()->yes()) {
 			return new ErrorType();
 		}
 
@@ -2087,7 +2087,7 @@
 			return new ErrorType();
 		}
 
-		if ($leftNumberType instanceof ErrorType || $rightNumberType instanceof ErrorType) {
+		if ($leftNumberType->isError()->yes() || $rightNumberType->isError()->yes()) {
 			return new ErrorType();
 		}
 		if ($leftNumberType instanceof NeverType || $rightNumberType instanceof NeverType) {

src/Reflection/Php/PhpClassReflectionExtension.php

@@ -41,7 +41,6 @@
 use PHPStan\Type\Constant\ConstantArrayTypeBuilder;
 use PHPStan\Type\Constant\ConstantStringType;
 use PHPStan\Type\Enum\EnumCaseObjectType;
-use PHPStan\Type\ErrorType;
 use PHPStan\Type\FileTypeMapper;
 use PHPStan\Type\GeneralizePrecision;
 use PHPStan\Type\Generic\TemplateMixedType;
@@ -1178,7 +1177,7 @@ private function inferAndCachePropertyTypes(
 			}
 
 			$propertyType = $methodScope->getType($expr->expr);
-			if ($propertyType instanceof ErrorType || $propertyType instanceof NeverType) {
+			if ($propertyType->isError()->yes() || $propertyType instanceof NeverType) {
 				continue;
 			}
 

src/Reflection/ResolvedFunctionVariantWithOriginal.php

@@ -4,7 +4,6 @@
 
 use PHPStan\Reflection\Php\ExtendedDummyParameter;
 use PHPStan\Type\ConditionalTypeForParameter;
-use PHPStan\Type\ErrorType;
 use PHPStan\Type\Generic\GenericObjectType;
 use PHPStan\Type\Generic\GenericStaticType;
 use PHPStan\Type\Generic\TemplateType;
@@ -211,7 +210,7 @@ private function resolveResolvableTemplateTypes(Type $type, TemplateTypeVariance
 				&& $type->getScope()->getFunctionName() !== null
 			) {
 				$newType = $this->resolvedTemplateTypeMap->getType($type->getName());
-				if ($newType === null || $newType instanceof ErrorType) {
+				if ($newType === null || $newType->isError()->yes()) {
 					return $traverse($type);
 				}
 
@@ -252,7 +251,7 @@ private function resolveResolvableTemplateTypes(Type $type, TemplateTypeVariance
 
 			if ($type instanceof TemplateType && !$type->isArgument()) {
 				$newType = $this->resolvedTemplateTypeMap->getType($type->getName());
-				if ($newType === null || $newType instanceof ErrorType) {
+				if ($newType === null || $newType->isError()->yes()) {
 					return $traverse($type);
 				}
 

src/Rules/Api/ApiInstanceofTypeRule.php

@@ -32,6 +32,7 @@
 use PHPStan\Type\Constant\ConstantStringType;
 use PHPStan\Type\ConstantScalarType;
 use PHPStan\Type\Enum\EnumCaseObjectType;
+use PHPStan\Type\ErrorType;
 use PHPStan\Type\FloatType;
 use PHPStan\Type\Generic\GenericClassStringType;
 use PHPStan\Type\Generic\GenericObjectType;
@@ -80,6 +81,7 @@ final class ApiInstanceofTypeRule implements Rule
 		IntersectionType::class => null,
 		ConstantScalarType::class => 'Type::isConstantScalarValue() or Type::getConstantScalarTypes() or Type::getConstantScalarValues()',
 		ObjectShapeType::class => 'Type::isObject() and Type::hasProperty()',
+		ErrorType::class => 'Type::isError()',
 
 		// accessory types
 		NonEmptyArrayType::class => 'Type::isIterableAtLeastOnce()',

src/Rules/Arrays/ArrayDestructuringRule.php

@@ -14,7 +14,6 @@
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Rules\RuleLevelHelper;
 use PHPStan\Type\Constant\ConstantIntegerType;
-use PHPStan\Type\ErrorType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 use PHPStan\Type\VerbosityLevel;
@@ -65,7 +64,7 @@ private function getErrors(Scope $scope, Node\Expr\List_ $var, Expr $expr): arra
 			static fn (Type $varType): bool => $varType->isArray()->yes() || (new ObjectType(ArrayAccess::class))->isSuperTypeOf($varType)->yes(),
 		);
 		$exprType = $exprTypeResult->getType();
-		if ($exprType instanceof ErrorType) {
+		if ($exprType->isError()->yes()) {
 			return [];
 		}
 		if (!$exprType->isArray()->yes() && !(new ObjectType(ArrayAccess::class))->isSuperTypeOf($exprType)->yes()) {

src/Rules/Arrays/ArrayUnpackingRule.php

@@ -11,7 +11,6 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Rules\RuleLevelHelper;
-use PHPStan\Type\ErrorType;
 use PHPStan\Type\Type;
 use PHPStan\Type\VerbosityLevel;
 use function sprintf;
@@ -46,7 +45,7 @@ public function processNode(Node $node, Scope $scope): array
 		);
 
 		$keyType = $typeResult->getType();
-		if ($keyType instanceof ErrorType) {
+		if ($keyType->isError()->yes()) {
 			return $typeResult->getUnknownClassErrors();
 		}
 

src/Rules/Arrays/InvalidKeyInArrayDimFetchRule.php

@@ -10,7 +10,6 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Rules\RuleLevelHelper;
-use PHPStan\Type\ErrorType;
 use PHPStan\Type\Type;
 use PHPStan\Type\VerbosityLevel;
 use function sprintf;
@@ -51,7 +50,7 @@ public function processNode(Node $node, Scope $scope): array
 			static fn (Type $varType): bool => $varType->isArray()->no(),
 		)->getType();
 
-		if ($varType instanceof ErrorType) {
+		if ($varType->isError()->yes()) {
 			return [];
 		}
 
@@ -67,7 +66,7 @@ public function processNode(Node $node, Scope $scope): array
 			'',
 			static fn (Type $dimType): bool => $allowedArrayKeys->isSuperTypeOf($dimType)->yes(),
 		)->getType();
-		if ($dimensionType instanceof ErrorType) {
+		if ($dimensionType->isError()->yes()) {
 			return [];
 		}
 

src/Rules/Arrays/InvalidKeyInArrayItemRule.php

@@ -10,7 +10,6 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Rules\RuleLevelHelper;
-use PHPStan\Type\ErrorType;
 use PHPStan\Type\Type;
 use PHPStan\Type\VerbosityLevel;
 use function sprintf;
@@ -49,7 +48,7 @@ public function processNode(Node $node, Scope $scope): array
 			'',
 			static fn (Type $dimType): bool => $allowedArrayKeys->isSuperTypeOf($dimType)->yes(),
 		)->getType();
-		if ($dimensionType instanceof ErrorType) {
+		if ($dimensionType->isError()->yes()) {
 			return [];
 		}
 

src/Rules/Arrays/IterableInForeachRule.php

@@ -9,7 +9,6 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Rules\RuleLevelHelper;
-use PHPStan\Type\ErrorType;
 use PHPStan\Type\Type;
 use PHPStan\Type\VerbosityLevel;
 use function sprintf;
@@ -40,7 +39,7 @@ public function processNode(Node $node, Scope $scope): array
 			static fn (Type $type): bool => $type->isIterable()->yes(),
 		);
 		$type = $typeResult->getType();
-		if ($type instanceof ErrorType) {
+		if ($type->isError()->yes()) {
 			return $typeResult->getUnknownClassErrors();
 		}
 		if ($type->isIterable()->yes()) {

src/Rules/Arrays/NonexistentOffsetInArrayDimFetchCheck.php

@@ -11,7 +11,6 @@
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Rules\RuleLevelHelper;
 use PHPStan\Type\BenevolentUnionType;
-use PHPStan\Type\ErrorType;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\NeverType;
 use PHPStan\Type\Type;
@@ -54,7 +53,7 @@ public function check(
 			static fn (Type $type): bool => $type->hasOffsetValueType($dimType)->yes(),
 		);
 		$type = $typeResult->getType();
-		if ($type instanceof ErrorType) {
+		if ($type->isError()->yes()) {
 			return $typeResult->getUnknownClassErrors();
 		}
 

src/Rules/Arrays/NonexistentOffsetInArrayDimFetchRule.php

@@ -15,7 +15,6 @@
 use PHPStan\Rules\RuleLevelHelper;
 use PHPStan\TrinaryLogic;
 use PHPStan\Type\Constant\ConstantIntegerType;
-use PHPStan\Type\ErrorType;
 use PHPStan\Type\Type;
 use PHPStan\Type\VerbosityLevel;
 use function count;
@@ -65,7 +64,7 @@ public function processNode(Node $node, Scope $scope): array
 			static fn (Type $type): bool => $type->isOffsetAccessible()->yes(),
 		);
 		$isOffsetAccessibleType = $isOffsetAccessibleTypeResult->getType();
-		if ($isOffsetAccessibleType instanceof ErrorType) {
+		if ($isOffsetAccessibleType->isError()->yes()) {
 			return $isOffsetAccessibleTypeResult->getUnknownClassErrors();
 		}