Skip to content

Fix phpstan/phpstan#4860: Error „should return static(Test) but returns Test“ #5190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staabm merged 1 commit into from
Mar 13, 2026
+33 −7
Merged

Fix phpstan/phpstan#4860: Error „should return static(Test) but returns Test“ #5190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Type/StaticType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
use PHPStan\Reflection\Type\UnresolvedPropertyPrototypeReflection;
use PHPStan\TrinaryLogic;
use PHPStan\Type\Enum\EnumCaseObjectType;
use PHPStan\Type\Generic\GenericClassStringType;
use PHPStan\Type\Generic\GenericObjectType;
use PHPStan\Type\Generic\TemplateTypeHelper;
use PHPStan\Type\Traits\NonGeneralizableTypeTrait;
Expand Down Expand Up @@ -200,7 +201,7 @@ public function isObject(): TrinaryLogic

public function getClassStringType(): Type
{
return $this->getStaticObjectType()->getClassStringType();
Copy link
Contributor

@VincentLanglet VincentLanglet Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method was initially implemented in #4456 where I just copied the strategy from other methods.

Copy link
Collaborator Author

@phpstan-bot phpstan-bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed - the RawErrorFormatterTest failure is pre-existing and completely unrelated to our changes. Our PR changes are limited to StaticType.php and test expectations.

Summary: The review comment from VincentLanglet is purely informational context - they noted that the original getClassStringType() implementation in PR #4456 just copied the delegation pattern from other methods (which is what caused the bug). No code changes are requested. The branch is clean, static analysis passes with no errors, and all tests related to our changes pass. The one failing test (RawErrorFormatterTest) is a pre-existing issue on the repository unrelated to this PR.

The branch is already pushed and up to date with origin/create-pull-request/patch-maf6i34, so there's nothing further to push.

return new GenericClassStringType($this);
}

public function isEnum(): TrinaryLogic
Expand Down
2 changes: 1 addition & 1 deletion tests/PHPStan/Analyser/data/bug-7391b.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public static function m() {
assertType('Bug7391B\Foo', (self::class)::m());
assertType('static(Bug7391B\Foo)', (static::class)::m());
assertType('Bug7391B\Foo', get_class(new self(2))::m());
assertType('Bug7391B\Foo', get_class(new static(2))::m());
assertType('static(Bug7391B\Foo)', get_class(new static(2))::m());

throw new \Error('For static analysis only, return type is resolved purely by DynamicStaticMethodReturnTypeExtension');
}
Expand Down
25 changes: 25 additions & 0 deletions tests/PHPStan/Analyser/nsrt/bug-4860.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<?php declare(strict_types = 1);

namespace Bug4860;

use function PHPStan\Testing\assertType;

class Test
{
public function copy(): static
{
assertType('class-string<$this(Bug4860\Test)>', get_class($this));
return $this->copyTo(get_class($this));
}

/**
* @template T
* @param class-string<T> $targetEntity
* @return T
*/
public function copyTo(string $targetEntity)
{
/** @var T */
return new $targetEntity();
}
}
2 changes: 1 addition & 1 deletion tests/PHPStan/Analyser/nsrt/get-parent-class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public function doFoo()
{
assertType('false', get_parent_class());
assertType('false', get_parent_class($this));
assertType('class-string<ParentClass\Foo>', get_class($this));
assertType('class-string<$this(ParentClass\Foo)>', get_class($this));
assertType('\'ParentClass\\\\Foo\'', get_class());
}

Expand Down
8 changes: 4 additions & 4 deletions tests/PHPStan/Rules/Comparison/StrictComparisonOfDifferentTypesRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ public function testBug3633(): void
$tipText = 'Because the type is coming from a PHPDoc, you can turn off this check by setting <fg=cyan>treatPhpDocTypesAsCertain: false</> in your <fg=cyan>%configurationFile%</>.';
$this->analyse([__DIR__ . '/data/bug-3633.php'], [
[
'Strict comparison using === between class-string<Bug3633\HelloWorld> and \'Bug3633\\\OtherClass\' will always evaluate to false.',
'Strict comparison using === between class-string<$this(Bug3633\HelloWorld)> and \'Bug3633\\\OtherClass\' will always evaluate to false.',
37,
$tipText,
],
Expand All @@ -580,7 +580,7 @@ public function testBug3633(): void
44,
],
[
'Strict comparison using === between class-string<Bug3633\OtherClass> and \'Bug3633\\\HelloWorld\' will always evaluate to false.',
'Strict comparison using === between class-string<$this(Bug3633\OtherClass)> and \'Bug3633\\\HelloWorld\' will always evaluate to false.',
64,
$tipText,
],
Expand All @@ -595,12 +595,12 @@ public function testBug3633(): void
$tipText,
],
[
'Strict comparison using === between class-string<Bug3633\FinalClass> and \'Bug3633\\\HelloWorld\' will always evaluate to false.',
'Strict comparison using === between class-string<$this(Bug3633\FinalClass)> and \'Bug3633\\\HelloWorld\' will always evaluate to false.',
93,
$tipText,
],
[
'Strict comparison using === between class-string<Bug3633\FinalClass> and \'Bug3633\\\OtherClass\' will always evaluate to false.',
'Strict comparison using === between class-string<$this(Bug3633\FinalClass)> and \'Bug3633\\\OtherClass\' will always evaluate to false.',
96,
$tipText,
],
Expand Down
Loading