Skip to content

Display the correct number of processes used, when using '--debug'.#5294

Merged
ondrejmirtes merged 7 commits intophpstan:2.1.xfrom
esthezia:2.1.x
Mar 25, 2026
Merged

Display the correct number of processes used, when using '--debug'.#5294
ondrejmirtes merged 7 commits intophpstan:2.1.xfrom
esthezia:2.1.x

Conversation

@esthezia
Copy link
Copy Markdown
Contributor

No description provided.

@ondrejmirtes
Copy link
Copy Markdown
Member

That’s not how I’d do it. The scheduler should only be called with !$debug. Meaning that the DiagnoseExtension should not print anything at all.

Also add e2e tests into e2e-tests.yml that asserts the output (or lack thereof).

@esthezia
Copy link
Copy Markdown
Contributor Author

esthezia commented Mar 24, 2026

The scheduler should only be called with !$debug. Meaning that the DiagnoseExtension should not print anything at all.

@ondrejmirtes What do you mean? From what I can see, the DiagnoseExtension prints this information if -vvv is used, whether --debug is given or not.

Added e2e tests.

@ondrejmirtes ondrejmirtes merged commit f047fbd into phpstan:2.1.x Mar 25, 2026
657 checks passed
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you.

@esthezia
Copy link
Copy Markdown
Contributor Author

Perfect! Thank you! 🙏

@esthezia
Copy link
Copy Markdown
Contributor Author

I want to add, for documentation purposes, that eventually, the output about parallel processing was removed completely when using --debug, as it's not relevant in this case, because --debug disables parallel processing. It will only be displayed when using -vvv without --debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants