Skip to content

Stop forwarding getRowsRequest / getRowsResponse into AG Grid options #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BSd3v merged 4 commits into from
Apr 24, 2026
+13 −6
Merged

Stop forwarding getRowsRequest / getRowsResponse into AG Grid options #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e6e33b
Initial plan
Copilot Apr 24, 2026
bf447dc
fix: avoid forwarding getRows request/response props to AG Grid
Copilot Apr 24, 2026
9af4927
Merge branch 'v35' into copilot/remove-warnings-get-rows
BSd3v Apr 24, 2026
2249a05
Update CHANGELOG.md
BSd3v Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ Links "DE#nnn" prior to version 2.0 point to the Dash Enterprise closed-source D

### Fixed
- [#454](https://github.com/plotly/dash-ag-grid/pull/454) fixes issue where a rowCount of 0 would cause the grid not to display new data
- [#417](https://github.com/plotly/dash-ag-grid/issues/417) fix grid rendering when `getRowId` is explicitly set to `None`
- [#459](https://github.com/plotly/dash-ag-grid/pull/459) removes `getRowsRequest` / `getRowsResponse` warnings by excluding these Dash callback props from AG Grid options.
- [#460](https://github.com/plotly/dash-ag-grid/pull/460) fix grid rendering when `getRowId` is explicitly set to `None`

## [35.2.0] - 2026-04-03
### Added
Expand Down
6 changes: 3 additions & 3 deletions src/lib/utils/propCategories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,8 @@ export const PROPS_NOT_FOR_AG_GRID = [
'cellValueChanged',
'cellClicked',
'cellDoubleClicked',
'getRowRequest',
'getRowResponse',
'getRowsRequest',
'getRowsResponse',
'getDetailRequest',
'getDetailResponse',
'dangerously_allow_code',
Expand Down Expand Up @@ -383,7 +383,7 @@ export const OMIT_PROP_RENDER = [
'virtualRowData',
'columnState',
'filterModel',
'getRowRequest',
'getRowsRequest',
'getDetailRequest',
'cellValueChanged',
'cellClicked',
Expand Down
10 changes: 8 additions & 2 deletions tests/test_infinite_scroll.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,13 @@ def scroll(n):
for x in range(8):
dash_duo.find_element("#scroll").click()
time.sleep(3) # pausing to emulate separation because user inputs
assert list(filter(lambda i: i.get("level") != "WARNING", dash_duo.get_logs())) == []
logs = dash_duo.get_logs()
assert list(filter(lambda i: i.get("level") != "WARNING", logs)) == []
assert not any(
"invalid gridOptions property 'getRowsRequest'" in log.get("message", "")
or "invalid gridOptions property 'getRowsResponse'" in log.get("message", "")
for log in logs
)

def test_is003_infinite_scroll_clear(dash_duo):
app = Dash(__name__)
Expand Down Expand Up @@ -330,4 +336,4 @@ def update_rfq_grid_rows(
)
dash_duo.find_element("#reset").click()
grid_dom.wait_for_cell_text(0, 0, "0")
assert x == len(test_data) # make sure the callback was called the expected number of times
assert x == len(test_data) # make sure the callback was called the expected number of times
Loading