Fix database-access for sharing records #409
Open
baronfac wants to merge 1 commit intopointfreeco:mainfrom
Open
Fix database-access for sharing records #409baronfac wants to merge 1 commit intopointfreeco:mainfrom
baronfac wants to merge 1 commit intopointfreeco:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When opening
CloudSharingViewfor a record that was not created by the current user, the following error occurs:This is reproducible in the
RemindersAppdemo.The issue is in CloudKitSharing.share(record:configure:), which always accesses privateCloudDatabase (line 178):
This fails for records owned by other users, since those exist in the shared database, not the private one.
Fix:
Resolve the database from the record's ID instead:
This ensures the correct database scope is used regardless of record ownership, and CloudSharingView opens as expected.