Fix MockCloudDatabase record mutation in modify callback#412
Open
lukaskubanek wants to merge 2 commits intopointfreeco:mainfrom
Open
Fix MockCloudDatabase record mutation in modify callback#412lukaskubanek wants to merge 2 commits intopointfreeco:mainfrom
MockCloudDatabase record mutation in modify callback#412lukaskubanek wants to merge 2 commits intopointfreeco:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
MockCloudDatabase.modifyRecords(…), the returned callback currently passes the saved records to the sync engine as-is (i.e. the internally copied and storedCKRecordinstances). This effectively shares the sameCKRecordobjects with the sync engine.Mutations performed on these records by the sync engine (such as updating
userModificationTimeas part of the upsert logic1) are therefore reflected in theMockCloudDatabase. As a result, the mock database can report incorrect results, as demonstrated by the newly introduced assertion in one of the merge conflict tests.This PR fixes the issue by returning copies of the records in the modify callback, preventing the coupling between the sync engine and
MockCloudDatabase.Footnotes
One could question whether directly mutating the
CKRecordin the upsert logic is appropriate, and whether a better approach exists (see #370). However, that’s a separate topic. ↩