You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @karlhorky , thanks for the PR!
I think there are going to be other problems if you put two deck-code-surfer components in the same slide. We need a different component for that use case.
If you want to try to rewrite deck-code-surfer-split I'd be happy to merge it.
Two deck-code-surfer components actually works surprisingly well, have this in a couple of decks so far since I developed this solution. I even have a deck that uses steps in both HTML and CSS at the same time to teach how selectors work, and this also works well.
What are your concerns? The only problem I've had so far is the sizing / zooming.
If there's something that I haven't thought about, then I'm all for considering other options (like rewriting the deck-code-surfer-split component with your guidance).
The decks I have are working pretty well though.
Aside from that, I could imagine that other use cases would also be served well from overriding the container styles. Do you have something against allowing this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MVP for #44 (comment)
Before:
After: