Update TruffleRuby URLs and dependencies #517
Conversation
eregon
force-pushed
the
update-truffleruby-urls-and-dependencies
branch
2 times, most recently
from
38a98a6 to
7b002c3
Compare
postmodern
left a comment
postmodern
left a comment
There was a problem hiding this comment.
Looks good, but we should add additional tests to test/truffleruby-tests/dependencies_tests.sh for when the truffleruby version is 33.x or greater in order to test when the openssl and libyaml dependencies are omitted. We could do that in this PR or in a separate PR/commit. Depends on how fast you want this merged.
|
Thanks for the review. It's not urgent, I'll add them in this PR. |
|
I noticed not all tests are run in CI: Line 12 in 204f5dd |
eregon
force-pushed
the
update-truffleruby-urls-and-dependencies
branch
2 times, most recently
from
a7c4011 to
1d0ac4b
Compare
|
All good and passing now. |
| # Same as truffleruby dependencies | ||
| source "${BASH_SOURCE[0]%/*}/../truffleruby/dependencies.sh" |
There was a problem hiding this comment.
Could also be a symlink, not sure what you prefer.
|
The ArchLinux and OpenSUSE failures are unrelated to this PR and preexisting. The same tests also fail on FreeBSD and additonally there truffleruby tests fail since BSD is not a supported platform for TruffleRuby. Could you take care of those by pushing extra commits to this PR? |
|
@postmodern Hello, any chance you could finish this up or just merge this PR? |
There was a problem hiding this comment.
The reason some of the tests are not being ran is the truffleruby shunit2 test files are named *_tests.sh instead of *_test.sh. If you rename test/truffleruby-tests/dependencies_tests.sh to test/truffleruby-tests/dependencies_test.sh, test/truffleruby-graalvm-tests/functions_tests.sh to test/truffleruby-graalvm-tests/functions_test.sh, and remove the test/runner change, the shunit2 test files should run.
I renamed all of the *_tests.sh files in the fix_test_file_names branch, but ran into a TruffleRuby FreeBSD detection issue once the files started running again.
* TruffleRuby does not currently support FreeBSD.
Not just those but all |
…ince they are the same
* See https://github.com/truffleruby/truffleruby/blob/master/doc/user/installing-libssl.md and https://github.com/truffleruby/truffleruby/blob/master/doc/user/installing-libyaml.md * libxml2 is not needed since 20.0 so just drop that: postmodern#359 (comment) * Fix order of arguments to assertEquals in tests.
eregon
force-pushed
the
update-truffleruby-urls-and-dependencies
branch
from
1d0ac4b to
cac480a
Compare
|
I rebased on top of |
|
@postmodern Thank you for fixing the CI. This should be ready to go after merging |
|
I will start preparing a patch release with these and other fixes in it. |
|
ruby-install 0.10.2 has now been released to coincide with the TruffleRuby 33 announcement. Just installed TruffleRuby 33 and the rest of my rubies. Unfortunately, I made one mistake and forgot to update the |
|
Thank you! |
2 participants
See individual commits for details.
FYI there is also postmodern/ruby-versions@e80b1c1