refactor: consolidate Algolia search into external js/algolia-search.js#801
Closed
Parth-Garg2629 wants to merge 4 commits intoprecice:masterfrom
Closed
refactor: consolidate Algolia search into external js/algolia-search.js#801Parth-Garg2629 wants to merge 4 commits intoprecice:masterfrom
Parth-Garg2629 wants to merge 4 commits intoprecice:masterfrom
Conversation
Member
|
Thank you for the contribution. There have been changes in With a first look at this PR, I think it is still strange that it keeps both files. In any case, this will be cleaned up in the context of the framework migration. Since the effort/iterations required to bring this PR in a mergeable state would be higher than the benefit it would bring, I am closing this now. The solution is much simpler: just remove the unused file. I did that now in #851 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Algolia search logic existed in two near-identical places:
Solution
window.ALGOLIA_CONFIGand loads the external JS filewindow.ALGOLIA_CONFIG, pure vanilla JS with no Liquid tagsBenefits
No functional changes
Search behaviour, styling, and UX are identical to before.
The 167 lines removed = the duplicate. The code that was identical in both files now lives in one place (
algolia-search.js). Nothing was deleted that wasn't already covered by the external file.
Closes #796