Fix infinite duplication bugs in subprojects.rb plugin#831
Open
praaatap wants to merge 1 commit intoprecice:masterfrom
Open
Fix infinite duplication bugs in subprojects.rb plugin#831praaatap wants to merge 1 commit intoprecice:masterfrom
praaatap wants to merge 1 commit intoprecice:masterfrom
Conversation
praaatap
changed the title
MakisH
added
GSoC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two mistakes in the [_plugins/subprojects.rb] Jekyll plugin. These mistakes caused file filtering and endless asset duplication.
1. Correct Path Context for Directory Filtering
The plugin checked if a file is a directory using
File.directory?(f).. Fis just the filename, likelogo.pngnot the full path. So Ruby checked the project root of theimages` subdirectory.File.join(images, f)to give the path.2. Fixed Infinite Duplication in Static Files
The code that tried to skip existing files did not work. The
existing_staticsSet had paths without a leading slash. The code checked againststatic_file.relative_pathwhich has a leading slash. This meant the same files were re-registered in every build loop..delete_prefix('/')to the comparison so both paths match.Impact
Prevents "Endless Rebuild Loops": Now Jekyll correctly identifies existing files and stops re-registering and re-writing the same assets.
** Performance**: We save memory and time by not processing the same assets multiple times.
Verification
I checked that the Ruby syntax is correct.
I confirmed that path comparisons now consistently exclude the leading slash, for matching.