systemtests: add per-test max_time override for precice-config #744
Open
AdityaGupta716 wants to merge 7 commits intoprecice:developfrom
Open
systemtests: add per-test max_time override for precice-config #744AdityaGupta716 wants to merge 7 commits intoprecice:developfrom
AdityaGupta716 wants to merge 7 commits intoprecice:developfrom
Conversation
Author
|
@MakisH Plz review |
Collaborator
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/gsoc-2026-aditya-gupta/2773/4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds per-test max_time override in tests.yaml so individual tests can cap preCICE simulation time without manually editing precice-config.xml.
What changed:
Systemtest: max_time is a proper dataclass field (not set externally after construction)
__apply_precice_max_time_override() applies the override after copying the tutorial, before running — works for both run() and run_for_reference_results() so reference generation is consistent with test runs
Handles multiple tags with a warning instead of silently ignoring them
TestSuite parses max_time from tests.yaml and passes it through everywhere including generate_reference_results.py
Usage:
yamlopenfoam_adapter_pr:
tutorials:
- path: perpendicular-flap
case_combination:
- fluid-openfoam
- solid-calculix
reference_result: ./perpendicular-flap/reference-results/...
max_time: 0.01
Closes #402